Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix fs.openSync() signature #38591

Closed
wants to merge 1 commit into from
Closed

doc: fix fs.openSync() signature #38591

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 8, 2021

The mode argument depends on the flags argument but it is optional
even if the flags argument is specified.

@lpinca
doc: fix fs.openSync() signature
fdbbd85 
The `mode` argument depends on the `flags` argument but it is optional
even if the `flags` argument is specified.
@github-actions github-actions bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 8, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2021
@Lxxyx Lxxyx added the fast-track PRs that do not need to wait for 48 hours to land. label May 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2021

Fast-track has been requested by @Lxxyx. Please 👍 to approve.

@lpinca
Copy link
Member Author

lpinca commented May 10, 2021

Landed in 63155c9.

@lpinca lpinca closed this May 10, 2021
@lpinca lpinca deleted the fix/fs-open-sync-signature branch May 10, 2021 14:08
lpinca added a commit that referenced this pull request May 10, 2021
@lpinca
doc: fix fs.openSync() signature
63155c9 
The `mode` argument depends on the `flags` argument but it is optional
even if the `flags` argument is specified.

PR-URL: #38591
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
moander pushed a commit to moander/node that referenced this pull request May 11, 2021
@lpinca @moander
doc: fix fs.openSync() signature
771ded3 
The `mode` argument depends on the `flags` argument but it is optional
even if the `flags` argument is specified.

PR-URL: nodejs#38591
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
moander pushed a commit to moander/node that referenced this pull request May 11, 2021
@lpinca @moander
doc: fix fs.openSync() signature
d18f264 
The `mode` argument depends on the `flags` argument but it is optional
even if the `flags` argument is specified.

PR-URL: nodejs#38591
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request May 17, 2021
@lpinca @targos
doc: fix fs.openSync() signature
d3de0ef 
The `mode` argument depends on the `flags` argument but it is optional
even if the `flags` argument is specified.

PR-URL: #38591
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@lpinca @targos
doc: fix fs.openSync() signature
c3ae1cf 
The `mode` argument depends on the `flags` argument but it is optional
even if the `flags` argument is specified.

PR-URL: #38591
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@trivikr trivikr trivikr approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@lpinca @Trott @addaleax @benjamingr @targos @cjihrig @Lxxyx @aduh95 @trivikr @RaisinTen