meta: post comment when pr labeled fast-track#38446
meta: post comment when pr labeled fast-track#38446jasnell wants to merge 2 commits intonodejs:masterfrom
Conversation
|
@nodejs/build ... my github actions skill is still fairly weak so I'd appreciate if someone could help verify this. |
|
Unfortunately you cannot test changes to a workflow that uses the pull_request_target event without landing them on a branch and opening a PR against that branch |
|
Maybe this should be merged with |
b893fb0 to
eb2b228
Compare
Signed-off-by: James M Snell <jasnell@gmail.com>
eb2b228 to
eedb34c
Compare
targos
left a comment
There was a problem hiding this comment.
LGTM. The file could be renamed to "comment-labeled.yml" or "labeled.yml"
mmarchini
left a comment
There was a problem hiding this comment.
Personally I would prefer the files to remain separate, merging them doesn't bring any value because there's no reuse between the two flows, and the only thing they share is the labeled event for PRs. Plus merging the files increase the complexity because now we need an extra condition in the if statement to skip the fast track job on issues.
I don't feel strong enough about it to ask to go back to separate files though.
|
@mmarchini ... I don't know if I was doing something wrong or what, but I actually had a difficult time getting the |
|
Landed in d85929c |
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38446 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Automatically adds a comment when a pull requests is labeled "fast-track"
Signed-off-by: James M Snell jasnell@gmail.com