Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update llhttp to 5.1.0 #38146

Closed
wants to merge 1 commit into from
Closed

Conversation

indutny
Copy link
Member

@indutny indutny commented Apr 8, 2021

cc @nodejs/http @nodejs/http2 Note that handling of h2 preamble has changed and llhttp now returns HPE_PAUSED_H2_UPGRADE error.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 8, 2021
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


Should this be backported?

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@indutny
Copy link
Member Author

indutny commented Apr 8, 2021

@mcollina possibly, but I the PRI * ... handling changes the behavior a bit so I'm wary of breaking existing code.

@mcollina
Copy link
Member

mcollina commented Apr 8, 2021

I've added a bunch of don't land labels to match this.

@mcollina mcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 8, 2021
@gengjiawen gengjiawen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2021
@indutny
Copy link
Member Author

indutny commented Apr 10, 2021

Landed in 6a1986d. Thank you!

@indutny indutny closed this Apr 10, 2021
indutny added a commit that referenced this pull request Apr 10, 2021
PR-URL: #38146
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
@indutny indutny deleted the feature/llhttp-5.0 branch April 10, 2021 21:32
@richardlau
Copy link
Member

It looks like this has broken the tests for body-parser and express: #37678 (comment)
cc @indutny @mcollina

denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 28, 2023
PR-URL: nodejs#38146
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>

# Conflicts:
#	deps/llhttp/README.md
#	deps/llhttp/include/llhttp.h
#	deps/llhttp/src/llhttp.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants