test: update parallel/test-crypto-keygen for OpenSSL 3 #38136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
This comment has been minimized.
This comment has been minimized.
OpenSSL 3 returns a different error code.
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Apr 7, 2021
This comment has been minimized.
This comment has been minimized.
tniessen
approved these changes
Apr 7, 2021
richardlau
added
the
author ready
|
There's really no reason for this to wait the 48 hours to land. Please 👍🏻 to fast-track |
jasnell
added
fast-track
panva
approved these changes
Apr 7, 2021
|
Landed in f9b63b8 |
jasnell
pushed a commit
that referenced
this pull request
Apr 7, 2021
OpenSSL 3 returns a different error code. PR-URL: #38136 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL 3 returns a different error code.
We've just enabled testing against a dynamically linked OpenSSL 3 (nodejs/build#2584) -- we did have a clean run on a copy of the job last week but that was before the test was recently changed in #37076.
cc @nodejs/crypto