test: fix test-tls-no-sslv3 for OpenSSL 3#38027
Closed
richardlau wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix test-tls-no-sslv3 for OpenSSL 3#38027richardlau wants to merge 1 commit intonodejs:masterfrom
richardlau wants to merge 1 commit intonodejs:masterfrom
Conversation
OpenSSL 3 has changed the format of the error message for an unknown option to the CLI. Update the test to allow for the older and newer message formats.
nodejs-github-bot
added
needs-ci
This was referenced Apr 1, 2021
Collaborator
danbev
approved these changes
Apr 2, 2021
Contributor
danbev
left a comment
danbev
left a comment
There was a problem hiding this comment.
LGTM!
I ran this against the OpenSSL upstream/master and noticed two new test failure but this test succeeds. I'll take a look at the test failures next week and also take a look at the compiler warnings which I thought I'd had managed to suppress.
cjihrig
approved these changes
Apr 2, 2021
richardlau
added
the
author ready
tniessen
approved these changes
Apr 3, 2021
danbev
pushed a commit
that referenced
this pull request
Apr 3, 2021
OpenSSL 3 has changed the format of the error message for an unknown option to the CLI. Update the test to allow for the older and newer message formats. PR-URL: #38027 Refs: openssl/openssl#10774 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Contributor
|
Landed in 0828a96. |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 4, 2021
OpenSSL 3 has changed the format of the error message for an unknown option to the CLI. Update the test to allow for the older and newer message formats. PR-URL: #38027 Refs: openssl/openssl#10774 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 5, 2021
OpenSSL 3 has changed the format of the error message for an unknown option to the CLI. Update the test to allow for the older and newer message formats. PR-URL: #38027 Refs: openssl/openssl#10774 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL 3 has changed the format of the error message for an unknown
option to the CLI. Update the test to allow for the older and newer
message formats.
Refs: openssl/openssl#10774
Example message from an OpenSSL 1.1.1 CLI:
OpenSSL 3.0.0 alpha13:
cc @danbev