-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riscv64: Add riscv64 configure #37980
Conversation
@luyahan Do you have riscv64 machines to verify this ? |
Yes i have a Hifive unleashed。And i had run test on it. |
To make riscv longterm support, any thought provide machines to our infra https://github.com/nodejs/build ? |
Our lab ony have two boards.But we have oredered Hifive unmatched that don't delivered ret. |
About May, PLCT Lab can get some riscv64 .borads and can donate it to Node.js ci |
v8 had been add riscv64 backend, so i open this pr to add riscv64 configure. Refs: nodejs#37856
How to retry |
Landed in 1d21a8d |
It kinds of flaky as long as Jenkins passed. It's fine. Thanks for the contribution :) |
Although riscv64 should be supported it fails to build, disable for now. ../deps/v8/src/codegen/riscv64/macro-assembler-riscv64.h:222:8: error: 'void v8::internal::TurboAssembler::JumpCodeObject(v8::internal::Register)' marked 'override', but does not override 222 | void JumpCodeObject(Register code_object) override; nodejs/node#37980
v8 had been add riscv64 backend, so i open this
pr to add riscv64 configure.
Fixes: #37856