Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: refactor [customInspectSymbol] #37834

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

himself65
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Mar 20, 2021
lib/internal/util.js Outdated Show resolved Hide resolved
lib/internal/util.js Outdated Show resolved Hide resolved
lib/internal/abort_controller.js Outdated Show resolved Hide resolved
lib/internal/event_target.js Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failures look real since the []s were removed, is that intentional?

@himself65
Copy link
Member Author

Path: parallel/test-eventtarget-memoryleakwarning
Error: --- stderr ---
node:assert:122
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'Possible EventTarget memory leak detected. 3 foo listeners added to AbortSignal. Use events.setMaxListeners() to increase limit'
- 'Possible EventTarget memory leak detected. 3 foo listeners added to [AbortSignal]. Use events.setMaxListeners() to increase limit'
    at Object.<anonymous> (/home/runner/work/node/node/test/common/index.js:517:14)
    at Object.MaxListenersExceededWarning (/home/runner/work/node/node/test/common/index.js:381:15)
    at process.<anonymous> (/home/runner/work/node/node/test/common/index.js:541:33)
    at process.emit (node:events:369:20)
    at doEmitWarning (node:internal/process/warning:70:11)
    at processTicksAndRejections (node:internal/process/task_queues:80:21) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'Possible EventTarget memory leak detected. 3 foo listeners added to AbortSignal. Use events.setMaxListeners() to increase limit',
  expected: 'Possible EventTarget memory leak detected. 3 foo listeners added to [AbortSignal]. Use events.setMaxListeners() to increase limit',
  operator: 'strictEqual'
}

lib/internal/util.js Outdated Show resolved Hide resolved
himself65 and others added 2 commits March 21, 2021 15:05
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciative of the work and involvement.

blocking for now just so this doesn't land with the breaking change before we've discussed why the breaking change is required or is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants