-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events: refactor [customInspectSymbol] #37834
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
93245d2
to
c938392
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failures look real since the []
s were removed, is that intentional?
Path: parallel/test-eventtarget-memoryleakwarning
Error: --- stderr ---
node:assert:122
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'Possible EventTarget memory leak detected. 3 foo listeners added to AbortSignal. Use events.setMaxListeners() to increase limit'
- 'Possible EventTarget memory leak detected. 3 foo listeners added to [AbortSignal]. Use events.setMaxListeners() to increase limit'
at Object.<anonymous> (/home/runner/work/node/node/test/common/index.js:517:14)
at Object.MaxListenersExceededWarning (/home/runner/work/node/node/test/common/index.js:381:15)
at process.<anonymous> (/home/runner/work/node/node/test/common/index.js:541:33)
at process.emit (node:events:369:20)
at doEmitWarning (node:internal/process/warning:70:11)
at processTicksAndRejections (node:internal/process/task_queues:80:21) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: 'Possible EventTarget memory leak detected. 3 foo listeners added to AbortSignal. Use events.setMaxListeners() to increase limit',
expected: 'Possible EventTarget memory leak detected. 3 foo listeners added to [AbortSignal]. Use events.setMaxListeners() to increase limit',
operator: 'strictEqual'
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciative of the work and involvement.
blocking for now just so this doesn't land with the breaking change before we've discussed why the breaking change is required or is a good idea.
No description provided.