crypto: fix crypto.verify callback invocation with a private keyobject

[panva]

fixes #37794

[panva]

Before

const crypto = require('crypto');
const assert = require('assert');

const data = Buffer.from('hello');
const { privateKey } = crypto.generateKeyPairSync('ed25519');
const signature = crypto.sign(null, data, privateKey);

assert(crypto.verify(null, data, privateKey, signature)); // OK

crypto.verify(null, data, privateKey, signature, (err, verified) => { // 💥
  assert(!err);
  assert(verified);
});
// node[49326]: ../src/crypto/crypto_sig.cc:850:static bool node::crypto::SignTraits::DeriveBits(node::Environment *, const node::crypto::SignConfiguration &, node::crypto::ByteSource *): Assertion `(params.key->GetKeyType()) == (kKeyTypePublic)' failed.

After

const crypto = require('crypto');
const assert = require('assert');

const data = Buffer.from('hello');
const { privateKey } = crypto.generateKeyPairSync('ed25519');
const signature = crypto.sign(null, data, privateKey);

assert(crypto.verify(null, data, privateKey, signature)); // OK

crypto.verify(null, data, privateKey, signature, (err, verified) => {
  assert(!err);
  assert(verified); // OK
});

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36774/

[panva]

cc @nodejs/crypto

[panva]

@jasnell should we fast-track and do v15.12.1?

[jasnell]

Yeah i think so

[panva]

👍 to fast-track

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36775/

[panva]

Landed in 5e6386e

[panva]

@nodejs/releasers This fixes a possible crash introduced in a new optional argument added to a stable API with yesterday's 15.12.0 release (#37500). We're proposing a quick 15.12.1 patch release.