Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 1648e050cade #37664

Merged
merged 1 commit into from
Mar 11, 2021
Merged

deps: V8: cherry-pick 1648e050cade #37664

merged 1 commit into from
Mar 11, 2021

Commits on Mar 11, 2021

  1. deps: V8: cherry-pick 1648e050cade

    Original commit message:
    
        torque: workaround stod() limitations on Solaris
    
        std::stod() on Solaris does not currently handle hex strings.
        This commit provides a workaround based on strtol() until proper
        stod() support is available.
    
        This was encountered while updating Node.js to V8 8.8. For more
        details see the following comment:
    
        nodejs#36139 (comment)
    
        Change-Id: I16ed80a817f6d9105e7153b10824b1fee8520432
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692746
        Reviewed-by: Michael Stanton <mvstanton@chromium.org>
        Commit-Queue: Michael Stanton <mvstanton@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#73255}
    
    Refs: v8/v8@1648e05
    PR-URL: nodejs#37664
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cjihrig committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    8a6d7a0 View commit details
    Browse the repository at this point in the history