perf_hooks: make Performance extend EventTarget

[targos]

Refs: https://www.w3.org/TR/hr-time/#sec-performance

[targos]

Test that passes with this change:

node/test/fixtures/wpt/hr-time/basic.any.js

Lines 30 to 37 in f3d3769

	test(function() {
	var didHandle = false;
	self.performance.addEventListener("testEvent", function() {
	didHandle = true;
	}, { once: true} );
	self.performance.dispatchEvent(new Event("testEvent"));
	assert_true(didHandle, "Performance extends EventTarget, so event dispatching should work.");
	}, "Performance interface extends EventTarget.");

[benjamingr]

LGTM

(Is the fact it's an EventTarget actually used by the spec anywhere?)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36504/

[targos]

@benjamingr It's used by another spec that extends Performance: https://developer.mozilla.org/en-US/docs/Web/API/Performance/resourcetimingbufferfull_event

I don't know if it's important for us to extend EventTarget. I mostly implemented this so we can stop skipping basic.any.js.

[benjamingr]

I don't know if it's important for us to extend EventTarget.

I think it's not very important - I think it's beneficial regardless since it aligns us with the spec and it lets developers write universal code more easily without actually increasing maintenance cost :)

[targos]

I suppose it's a (very minor 😄) semver-minor change.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36511/

[jasnell]

semver-extremely-minor ;-)

It is odd to have an EventTarget with no events but ok.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36537/

[targos]

Landed in 5d4fc63

[danielleadams]

@targos can you create a backport PR for this for v15.x-staging? It doesn't land cleanly because #37136 is a semver major change. Thank you!

[targos]

#37467 should land first. Does it also need to be backported?

[danielleadams]

#37467 landed fine - no need for a backport.

[targos]

Okay, I'll just wait for v15.x-staging to be pushed and I'll backport.

[danielleadams]

@targos v15.x-staging is up to date