doc: remove generated from dsaEncoding description#37459
doc: remove generated from dsaEncoding description#37459kaznovac wants to merge 2 commits intonodejs:masterfrom
Conversation
Trott
left a comment
There was a problem hiding this comment.
LGTM. Can you fix the typographical error (generted->generated) in the commit message?
remove term `generated` from `dsaEncoding` parameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action'
|
@Trott @mscdex thank you both for the review @Trott i've fixed typo in the commit message @mscdex my rationale is that |
|
I probably wrote these descriptions. I agree with @mscdex, but I don't feel strongly about it.
Following this argument, I guess just having documentation breaks DRY. Just look at the code instead, it has all the information 😉 |
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
|
Landed in 4947ce5 |
remove term
generatedfromdsaEncodingparameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action'Fixes: #37454