Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 0c8b6e415c30 #37295

Closed
wants to merge 1 commit into from

Commits on Feb 9, 2021

  1. deps: V8: cherry-pick 0c8b6e415c30

    Original commit message:
    
        [mac][wasm] Work around MacOS 11.2 code page decommit failures
    
        MacOS 11.2 refuses to set "no access" permissions on memory that
        we previously used for JIT-compiled code. It is still unclear
        whether this is WAI on the part of the kernel. In the meantime,
        as a workaround, we use madvise(..., MADV_FREE_REUSABLE) instead
        of mprotect(..., NONE) when discarding code pages. This is inspired
        by what Chromium's gin platform does.
    
        Fixed: v8:11389
        Change-Id: I866586932573b4253002436ae5eee4e0411c45fc
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679688
        Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
        Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
        Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
        Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#72559}
    
    Refs: v8/v8@0c8b6e4
    mcollina committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    f1d20b9 View commit details
    Browse the repository at this point in the history