-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: improve fsPromises docs #37186
doc: improve fsPromises docs #37186
Conversation
Linter is failing. |
60c4160
to
70d6b36
Compare
At some day - I will figure out a workflow that will let me deal with the fact Node is the one project I often force-push to :D and I'll stop forgetting to check I did not get the "Updates were rejected" message. |
|
||
`length` is an integer specifying the number of bytes to read. | ||
|
||
`position` is an argument specifying where to begin reading from in the file. | ||
If `position` is `null`, data will be read from the current file position, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If `position` is `null`, data will be read from the current file position, | |
If `position` is `null` or `-1`, data will be read from the current file position, |
@benjamingr ... could these changes be bundled in with this PR instead to prevent conflicts? #37170 |
@jasnell sure. I'd also like to apologize for about landing the It would be super useful to have automation to tell you if changes you are proposing conflict with other open PRs. |
@jasnell Would you prefer it if I pushed the changes to your branch or wait for it to land before re-opening this PR? |
Feel free to push to my branch if you'd like. |
And no worries about the conflicts. We can get that rebased pretty easily |
Improe the filesystem promises docs:
I wanted to put all the changes here - but this PR got pretty big pretty fast so I figured I'd split the changes into multiple smaller PRs to make review reasonable and reduce the amount of potential conflicts.
CC @RaisinTen