fs: allow passing negative zero fd#37123
Merged
Trott merged 1 commit intonodejs:masterfrom Feb 6, 2021
Merged
Conversation
nodejs-github-bot
added
the
fs
Collaborator
aduh95
approved these changes
Jan 29, 2021
Member
Author
Contributor
I canceled it – when a lot of changes are being pushed at the same time to the repo, we are hitting GH Actions limitations and sometimes it takes hours for all the CI to complete. So I try to cancel jobs on commits which has more recents commits on the same PR as we don't need those anyway. |
Collaborator
aduh95
added
the
author ready
Lxxyx
approved these changes
Jan 29, 2021
mscdex
reviewed
Jan 29, 2021
juanarbol
previously requested changes
Jan 30, 2021
aduh95
removed
the
author ready
Collaborator
aduh95
dismissed
juanarbol’s stale review
He confirmed his suggestion is not a blocker in a comment above.
aduh95
added
the
author ready
Collaborator
Collaborator
RaisinTen
force-pushed
the
fs/fix-negative-zero-for-fd
branch
from
0e9d2b8 to
8dfb8f5
Compare
Member
Author
|
Rebased to resolve the conflicts. Restarting the CI. |
Collaborator
Collaborator
Trott
approved these changes
Feb 6, 2021
Fixes: nodejs#37122 PR-URL: nodejs#37123 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
force-pushed
the
fs/fix-negative-zero-for-fd
branch
from
016550c to
6b8b165
Compare
Member
|
Landed in 6b8b165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #37122