Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: deprecate "main" index and extension lookups #36918

Closed
wants to merge 18 commits into from
Closed

module: deprecate "main" index and extension lookups #36918

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
92b2565
module: "type": "module" legacy main deprecate
guybedford Jan 13, 2021
6c21f23
add pr link
guybedford Jan 13, 2021
318b0d0
put deprecation behind --pending-deprecation
guybedford Jan 13, 2021
d6df580
deprecate index main and extension lookups instead
guybedford Jan 15, 2021
7dfb539
update deprecation
guybedford Jan 15, 2021
e1821cf
remove spec change
guybedford Jan 15, 2021
2ce9740
Apply suggestions from code review
guybedford Jan 15, 2021
7885f07
fixup refs
guybedford Jan 15, 2021
a8208b2
Update lib/internal/modules/esm/resolve.js
guybedford Jan 15, 2021
08af32f
Update deprecations.md
guybedford Jan 15, 2021
1c079c0
Apply suggestions from code review
guybedford Jan 15, 2021
64c741c
Apply suggestions from code review
guybedford Jan 15, 2021
8a89c77
fixup linting
guybedford Jan 15, 2021
d808279
fix rebase issue
guybedford Jan 23, 2021
915c433
formatting
guybedford Jan 23, 2021
ead9e3a
Apply suggestions from code review
guybedford Jan 23, 2021
d2853f8
Apply suggestions from code review
guybedford Jan 23, 2021
c06baa3
capitalize comments
guybedford Jan 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@guybedford @aduh95
guybedford and aduh95 committed Jan 23, 2021
commit 2ce97400424608cae818d3e40e39b9c73a7dc149
7 changes: 4 additions & 3 deletions doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2730,16 +2730,17 @@ change the value has been deprecated and will be disabled in the future.
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/36918
description: Documentation-only deprecation.
description: Documentation-only deprecation
with `--pending-deprecation` support.
-->

Type: Documentation (supports [`--pending-deprecation`][])
Type: Documentation-only (supports [`--pending-deprecation`][])

Previously, `index.js` and extension searching lookups would apply to
`import 'pkg'` main entry point resolution, even when resolving ES modules.

With this deprecation, all ES module main entry point resolutions require
an explicit `"exports"` or `"main"` entry with the exact file extension.
an explicit [`"exports"`][] or [`"main"`][] entry with the exact file extension.


[Legacy URL API]: url.md#url_legacy_url_api
Expand Down