src: replace push_back with emplace_back in debug_utils #36897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
jasnell
approved these changes
Jan 12, 2021
RaisinTen
added
the
author ready
This prevents potential temporary object constructions. PR-URL: nodejs#36897 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
src/replace-push_back-with-emplace_back-in-debug_utils
branch
from
c7bfd1e
to
4ae3135
Compare
|
Landed in 4ae3135 |
RaisinTen
deleted the
src/replace-push_back-with-emplace_back-in-debug_utils
branch
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
This prevents potential temporary object constructions. PR-URL: #36897 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Jan 25, 2021
This prevents potential temporary object constructions. PR-URL: #36897 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
This prevents potential temporary object constructions. PR-URL: #36897 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents potential temporary object constructions.