crypto: fix WebCrypto import of RSA-PSS keys #36877
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
4 tasks
jasnell
approved these changes
Jan 11, 2021
panva
approved these changes
Jan 11, 2021
richardlau
approved these changes
Jan 11, 2021
cjihrig
approved these changes
Jan 11, 2021
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM. The linter seems to be complaining about the test though.
tniessen
force-pushed
the
webcrypto-pss-fips
branch
from
a5e3daf to
d39102e
Compare
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This patch changes GetRsaKeyDetail to work in older supported versions of OpenSSL. Refs: openssl/openssl#10217
tniessen
force-pushed
the
webcrypto-pss-fips
branch
from
d39102e to
1a74096
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
tniessen
added
the
author ready
panva
approved these changes
Jan 13, 2021
panva
pushed a commit
that referenced
this pull request
Jan 13, 2021
This patch changes GetRsaKeyDetail to work in older supported versions of OpenSSL. Refs: openssl/openssl#10217 PR-URL: #36877 Refs: #36188 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
Landed in 6a7eb32 |
tniessen
removed
the
author ready
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
This patch changes GetRsaKeyDetail to work in older supported versions of OpenSSL. Refs: openssl/openssl#10217 PR-URL: #36877 Refs: #36188 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes
GetRsaKeyDetailto work in older supported versions of OpenSSL. The added test case fails CI without this patch.I assume the WebCrypto implementation also does not handle imported
RSASSA-PSS-paramscorrectly, but it is out of scope for this PR to fix that. Last time I checked, OpenSSL made that step difficult.Refs: openssl/openssl#10217
Refs: #36188