Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: fix .end() error propagation #36817

Closed
wants to merge 4 commits into from
Closed

stream: fix .end() error propagation #36817

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db00cc2
stream: fix .end() error propagation
ronag Jan 6, 2021
5c7e371
fixup
ronag Jan 6, 2021
48ea4c2
fixup
ronag Jan 6, 2021
5443a22
fixup
ronag Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Jan 6, 2021
commit 48ea4c2c31dfb21b9439024a1140dd5757cf0023
6 changes: 4 additions & 2 deletions test/parallel/test-stream-writable-end-cb-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,13 @@ const stream = require('stream');
setImmediate(callback);
}
});
w.end('testing ended state', common.mustCall());
w.end('testing ended state', common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
}));
assert.strictEqual(w.destroyed, false);
assert.strictEqual(w.writableEnded, true);
w.end(common.mustCall((err) => {
assert.strictEqual(err.code, 'ERR_STREAM_WRITE_AFTER_END');
assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
}));
assert.strictEqual(w.destroyed, false);
assert.strictEqual(w.writableEnded, true);
Expand Down