Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: fix behaviour of Interface plugged to a non-terminal output #36774

Merged
merged 1 commit into from
Jan 6, 2021
Merged

readline: fix behaviour of Interface plugged to a non-terminal output #36774

merged 1 commit into from
Jan 6, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 4, 2021

Fixes: #36773

/cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • Tests are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Jan 4, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 4, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35291/

@aduh95
readline: fix behaviour of Interface plugged to a non-terminal output
fffdaeb 
Fixes: nodejs#36773

PR-URL: nodejs#36774
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@aduh95 aduh95 force-pushed the setupHistory-non-terminal-repl branch from 233432d to fffdaeb Compare January 6, 2021 17:45
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 6, 2021

Landed in fffdaeb

@aduh95 aduh95 merged commit fffdaeb into nodejs:master Jan 6, 2021
@aduh95 aduh95 deleted the setupHistory-non-terminal-repl branch January 6, 2021 17:46
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@aduh95 @danielleadams
readline: fix behaviour of Interface plugged to a non-terminal output
b17130a 
Fixes: #36773

PR-URL: #36774
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@aduh95 @targos
readline: fix behaviour of Interface plugged to a non-terminal output
70cbe4a 
Fixes: #36773

PR-URL: #36774
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.setupHistory() for non-terminal REPL fails
5 participants
@aduh95 @nodejs-github-bot @addaleax @cjihrig @Lxxyx