v15.5.0 release proposal

.eslintrc.js

@@ -234,6 +234,8 @@ module.exports = {
     'no-unreachable': 'error',
     'no-unsafe-finally': 'error',
     'no-unsafe-negation': 'error',
+    'no-unsafe-optional-chaining': 'error',
+    'no-unused-expressions': ['error', { allowShortCircuit: true }],
     'no-unused-labels': 'error',
     'no-unused-vars': ['error', { args: 'none', caughtErrors: 'all' }],
     'no-use-before-define': ['error', {

.github/PULL_REQUEST_TEMPLATE.md

@@ -7,6 +7,10 @@ Bug fixes and new features should include tests and possibly benchmarks.
 Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
 -->
 
+#### Related Issues
+
+Fixes: https://github.com/nodejs/node/issues/<issue_number>
+
 ##### Checklist
 <!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
 

.github/workflows/build-tarball.yml

@@ -13,6 +13,7 @@ env:
 
 jobs:
   build-tarball:
+    if: github.event.pull_request.draft == false
     env:
       PYTHON_VERSION: 3.9
     runs-on: ubuntu-latest

.github/workflows/build-windows.yml

@@ -15,6 +15,7 @@ env:
 
 jobs:
   build-windows-with-quic:
+    if: github.event.pull_request.draft == false
     runs-on: windows-latest
     steps:
       - uses: actions/checkout@v2

.github/workflows/close-stalled.yml

@@ -5,6 +5,7 @@ on:
 
 jobs:
   stale:
+    if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
     - uses: actions/stale@v3

.github/workflows/comment-stalled.yml

@@ -7,6 +7,7 @@ on:
 
 jobs:
   staleComment:
+    if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
       - name: Post comment

.github/workflows/coverage-linux.yml

@@ -22,6 +22,7 @@ env:
 
 jobs:
   coverage-linux:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2

.github/workflows/coverage-windows.yml

@@ -22,6 +22,7 @@ env:
 
 jobs:
   coverage-windows:
+    if: github.event.pull_request.draft == false
     runs-on: windows-latest
     steps:
       - uses: actions/checkout@v2

.github/workflows/license-builder.yml

@@ -7,7 +7,8 @@ on:
   workflow_dispatch:
 
 jobs:
-  update_routes:
+  update_license:
+    if: github.repository == 'nodejs/node'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2

.github/workflows/linters.yml

@@ -14,6 +14,7 @@ env:
 
 jobs:
   lint-addon-docs:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -26,6 +27,7 @@ jobs:
       - name: Lint addon docs
         run: NODE=$(command -v node) make lint-addon-docs
   lint-cpp:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -38,6 +40,7 @@ jobs:
       - name: Lint C/C++ files
         run: make lint-cpp
   lint-md:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -52,6 +55,7 @@ jobs:
           echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json"
           NODE=$(command -v node) make lint-md
   lint-js:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -64,6 +68,7 @@ jobs:
       - name: Lint JavaScript files
         run: NODE=$(command -v node) make lint-js
   lint-py:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -77,8 +82,16 @@ jobs:
         run: |
           make lint-py-build || true
           NODE=$(command -v node) make lint-py
-
+  lint-sh:
+    if: github.event.pull_request.draft == false
+    runs-on: ubuntu-20.04
+    steps:
+      - uses: actions/checkout@v2
+      - run: shellcheck -V
+      - name: Lint Shell scripts
+        run: tools/lint-sh.js .
   lint-codeowners:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2

.github/workflows/misc.yml

@@ -13,6 +13,7 @@ env:
 
 jobs:
   build-docs:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2

.github/workflows/test-asan.yml

@@ -19,6 +19,7 @@ env:
 
 jobs:
   test-asan:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     env:
       CC: clang

.github/workflows/test-linux.yml

@@ -15,6 +15,7 @@ env:
 
 jobs:
   test-linux:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
@@ -30,6 +31,7 @@ jobs:
         run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions"
 
   test-linux-with-quic:
+    if: github.event.pull_request.draft == false
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2

.github/workflows/test-macos.yml

@@ -15,6 +15,7 @@ env:
 
 jobs:
   test-macOS-with-quic:
+    if: github.event.pull_request.draft == false
     runs-on: macos-latest
     steps:
       - uses: actions/checkout@v2

BUILDING.md

@@ -30,6 +30,7 @@ file a new issue.
     * [Building the documentation](#building-the-documentation)
     * [Building a debug build](#building-a-debug-build)
     * [Building an ASAN build](#building-an-asan-build)
+    * [Speeding up frequent rebuilds when developing](#speeding-up-frequent-rebuilds-when-developing)
     * [Troubleshooting Unix and macOS builds](#troubleshooting-unix-and-macos-builds)
   * [Windows](#windows)
     * [Prerequisites](#prerequisites)
@@ -527,6 +528,29 @@ $  ./configure --debug --enable-asan && make -j4
 $ make test-only
 ```
 
+#### Speeding up frequent rebuilds when developing
+
+If you plan to frequently rebuild Node.js, especially if using several branches,
+installing `ccache` can help to greatly reduce build times. Set up with:
+```console
+$ sudo apt install ccache   # for Debian/Ubuntu, included in most Linux distros
+$ ccache -o cache_dir=<tmp_dir>
+$ ccache -o max_size=5.0G
+$ export CC="ccache gcc"    # add to your .profile
+$ export CXX="ccache g++"   # add to your .profile
+```
+This will allow for near-instantaneous rebuilds even when switching branches.
+
+When modifying only the JS layer in `lib`, it is possible to externally load it
+without modifying the executable:
+```console
+$ ./configure --node-builtin-modules-path $(pwd)
+```
+The resulting binary won't include any JS files and will try to load them from
+the specified directory. The JS debugger of Visual Studio Code supports this
+configuration since the November 2020 version and allows for setting
+breakpoints.
+
 #### Troubleshooting Unix and macOS builds
 
 Stale builds can sometimes result in `file not found` errors while building.

CHANGELOG.md

@@ -32,7 +32,9 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V15.md#15.3.0">15.3.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V15.md#15.5.0">15.5.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V15.md#15.4.0">15.4.0</a><br/>
+<a href="doc/changelogs/CHANGELOG_V15.md#15.3.0">15.3.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V15.md#15.2.1">15.2.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V15.md#15.2.0">15.2.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V15.md#15.1.0">15.1.0</a><br/>

GOVERNANCE.md

@@ -151,8 +151,9 @@ The nomination passes if no Collaborators oppose it after one week. Otherwise,
 the nomination fails.
 
 There are steps a nominator can take in advance to make a nomination as
-frictionless as possible. Use the [Collaborators discussion page][] to request
-feedback from other Collaborators in private. A nominator may also work with the
+frictionless as possible. To request feedback from other Collaborators in
+ private, use the [Collaborators discussion page][]
+ (which only Collaborators may view). A nominator may also work with the
 nominee to improve their contribution profile.
 
 Collaborators might overlook someone with valuable contributions. In that case,

LICENSE

@@ -1248,12 +1248,12 @@ The externally maintained libraries used by Node.js are:
     THE SOFTWARE.
   """
 
-- babel-eslint, located at tools/node_modules/babel-eslint, is licensed as follows:
+- Babel, located at tools/node_modules/@babel, is licensed as follows:
   """
-    Copyright (c) 2014-2016 Sebastian McKenzie <sebmck@gmail.com>
-
     MIT License
 
+    Copyright (c) 2014-present Sebastian McKenzie and other contributors
+
     Permission is hereby granted, free of charge, to any person obtaining
     a copy of this software and associated documentation files (the
     "Software"), to deal in the Software without restriction, including

Makefile

@@ -593,7 +593,7 @@ test-known-issues: all
 
 # Related CI job: node-test-npm
 test-npm: $(NODE_EXE) ## Run the npm test suite on deps/npm.
-	$(NODE) tools/test-npm-package --install --logfile=test-npm.tap deps/npm test-node
+	$(NODE) tools/test-npm-package --install --logfile=test-npm.tap deps/npm test
 
 test-npm-publish: $(NODE_EXE)
 	npm_package_config_publishtest=true $(NODE) deps/npm/test/run.js

README.md

@@ -34,6 +34,7 @@ The Node.js project uses an [open governance model](./GOVERNANCE.md). The
   * [TSC (Technical Steering Committee)](#tsc-technical-steering-committee)
   * [Collaborators](#collaborators)
   * [Release Keys](#release-keys)
+* [License](#license)
 
 ## Support
 
@@ -284,8 +285,6 @@ For information about the governance of the Node.js project, see
 **Danielle Adams** <adamzdanielle@gmail.com> (she/her)
 * [davisjam](https://github.com/davisjam) -
 **Jamie Davis** <davisjam@vt.edu> (he/him)
-* [DerekNonGeneric](https://github.com/DerekNonGeneric) -
-**Derek Lewis** <DerekNonGeneric@inf.is> (he/him)
 * [devnexen](https://github.com/devnexen) -
 **David Carlier** <devnexen@gmail.com>
 * [devsnek](https://github.com/devsnek) -
@@ -372,6 +371,8 @@ For information about the governance of the Node.js project, see
 **Ali Ijaz Sheikh** <ofrobots@google.com> (he/him)
 * [oyyd](https://github.com/oyyd) -
 **Ouyang Yadong** <oyydoibh@gmail.com> (he/him)
+* [PoojaDurgad](https://github.com/PoojaDurgad) -
+**Pooja D P** <Pooja.D.P@ibm.com> (she/her)
 * [psmarshall](https://github.com/psmarshall) -
 **Peter Marshall** <petermarshall@chromium.org> (he/him)
 * [puzpuzpuz](https://github.com/puzpuzpuz) -
@@ -459,6 +460,8 @@ For information about the governance of the Node.js project, see
 **Claudio Rodriguez** <cjrodr@yahoo.com>
 * [DavidCai1993](https://github.com/DavidCai1993) -
 **David Cai** <davidcai1993@yahoo.com> (he/him)
+* [DerekNonGeneric](https://github.com/DerekNonGeneric) -
+**Derek Lewis** <DerekNonGeneric@inf.is> (he/him)
 * [digitalinfinity](https://github.com/digitalinfinity) -
 **Hitesh Kanwathirtha** <digitalinfinity@gmail.com> (he/him)
 * [eljefedelrodeodeljefe](https://github.com/eljefedelrodeodeljefe) -
@@ -574,6 +577,8 @@ maintaining the Node.js project.
 
 * [PoojaDurgad](https://github.com/PoojaDurgad) -
 **Pooja Durgad** <Pooja.D.P@ibm.com>
+* [RaisinTen](https://github.com/RaisinTen) -
+**Darshan Sen** <raisinten@gmail.com>
 
 ### Release Keys
 
@@ -641,6 +646,14 @@ Other keys used to sign some previous releases:
 * **Timothy J Fontaine** <tjfontaine@gmail.com>
 `7937DFD2AB06298B2293C3187D33FF9D0246406D`
 
+## License
+
+Node.js is available under the
+[MIT license](https://opensource.org/licenses/MIT). Node.js also includes
+external libraries that are available under a variety of licenses.  See
+[LICENSE](https://github.com/nodejs/node/blob/master/LICENSE) for the full
+license text.
+
 [Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md
 [Contributing to the project]: CONTRIBUTING.md
 [Node.js Website]: https://nodejs.org/

benchmark/_benchmark_progress.js

@@ -39,7 +39,6 @@ class BenchmarkProgress {
     this.completedConfig = 0;
     // Total number of configurations for the current file
     this.scheduledConfig = 0;
-    this.interval;  // Updates the elapsed time.
   }
 
   startQueue(index) {

benchmark/child_process/child-process-params.js

@@ -82,6 +82,7 @@ function main({ n, methodName, params }) {
       }
       break;
     case 'execFileSync':
+    case 'spawnSync':
       switch (params) {
         case 1:
           bench.start();
@@ -119,24 +120,5 @@ function main({ n, methodName, params }) {
           break;
       }
       break;
-    case 'spawnSync':
-      switch (params) {
-        case 1:
-          bench.start();
-          for (let i = 0; i < n; i++) method(command);
-          bench.end(n);
-          break;
-        case 2:
-          bench.start();
-          for (let i = 0; i < n; i++) method(command, args);
-          bench.end(n);
-          break;
-        case 3:
-          bench.start();
-          for (let i = 0; i < n; i++) method(command, args, options);
-          bench.end(n);
-          break;
-      }
-      break;
   }
 }

benchmark/es/destructuring-bench.js

@@ -12,7 +12,8 @@ function runSwapManual(n) {
   let x, y, r;
   bench.start();
   for (let i = 0; i < n; i++) {
-    x = 1, y = 2;
+    x = 1;
+    y = 2;
     r = x;
     x = y;
     y = r;
@@ -26,7 +27,8 @@ function runSwapDestructured(n) {
   let x, y;
   bench.start();
   for (let i = 0; i < n; i++) {
-    x = 1, y = 2;
+    x = 1;
+    y = 2;
     [x, y] = [y, x];
     assert.strictEqual(x, 2);
     assert.strictEqual(y, 1);

benchmark/perf_hooks/bench-eventlooputil.js

@@ -33,7 +33,7 @@ function main({ method, n }) {
 function benchIdleTime(n) {
   bench.start();
   for (let i = 0; i < n; i++)
-    nodeTiming.idleTime;
+    nodeTiming.idleTime; // eslint-disable-line no-unused-expressions
   bench.end(n);
 }