Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Revise Github to GitHub #36359

Closed

Conversation

iam-frankqiu
Copy link
Contributor

Revise Github to GitHub.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should be added to the Markdown linter.

@DerekNonGeneric DerekNonGeneric added the doc Issues and PRs related to the documentations. label Dec 3, 2020
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to things under deps should be upstreamed first, in this case to https://github.com/nodejs/node-inspect/

@iam-frankqiu
Copy link
Contributor Author

Changes to things under deps should be upstreamed first, in this case to https://github.com/nodejs/node-inspect/

All right. I have created a pull request to node-inspect. Just waiting for the merge. nodejs/node-inspect#95

@Trott
Copy link
Member

Trott commented Dec 4, 2020

Yeah, this should be added to the Markdown linter.

It does! Just not in the deps folder because we don't control what other vendors do.

@Trott
Copy link
Member

Trott commented Dec 4, 2020

Changes to things under deps should be upstreamed first, in this case to https://github.com/nodejs/node-inspect/

All right. I have created a pull request to node-inspect. Just waiting for the merge. nodejs/node-inspect#95

It has to be landed and then put in a release so it may be a while. I don't think we want to float a patch for this.

I'm going to close this because this will have to come through a node-inspect update and not a PR here directly. Thanks for the PR and do comment or re-open if there's a reason this should remain open.

@Trott Trott closed this Dec 4, 2020
@iam-frankqiu
Copy link
Contributor Author

I'm going to close this because this will have to come through a node-inspect update and not a PR here directly. Thanks for the PR and do comment or re-open if there's a reason this should remain open.

I am sorry for my unknown. Thank you.

@iam-frankqiu
Copy link
Contributor Author

I'm going to close this because this will have to come through a node-inspect update and not a PR here directly. Thanks for the PR and do comment or re-open if there's a reason this should remain open.

The node-inspect package has merged my pull request. Could I update it in the deps folder directly?

@Trott
Copy link
Member

Trott commented Dec 12, 2020

The node-inspect package has merged my pull request. Could I update it in the deps folder directly?

We typically wait for them to do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants