-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add missing version to update cmd #36204
Closed
ruyadorno
wants to merge
1
commit into
nodejs:master
from
ruyadorno:docs-maintaining-npm-guide-patch
Closed
doc: add missing version to update cmd #36204
ruyadorno
wants to merge
1
commit into
nodejs:master
from
ruyadorno:docs-maintaining-npm-guide-patch
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add to the example of running `./tools/update-npm.sh` the missing reference to the version number that is required by the command.
richardlau
approved these changes
Nov 20, 2020
MylesBorins
approved these changes
Nov 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lpinca
approved these changes
Nov 21, 2020
Trott
approved these changes
Nov 23, 2020
Landed in cb5acc8 |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 23, 2020
Add to the example of running `./tools/update-npm.sh` the missing reference to the version number that is required by the command. PR-URL: #36204 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
Add to the example of running `./tools/update-npm.sh` the missing reference to the version number that is required by the command. PR-URL: #36204 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Add to the example of running `./tools/update-npm.sh` the missing reference to the version number that is required by the command. PR-URL: #36204 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to the example of running
./tools/update-npm.sh
the missing reference to the version number that is required by the command.Checklist
make lint
passes