Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use global.EventTarget instead of internals #36002

Merged
merged 1 commit into from
Nov 9, 2020
Merged

test: use global.EventTarget instead of internals #36002

merged 1 commit into from
Nov 9, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 6, 2020

EventTarget and Event are available from the global scope, there is no need to use the --expose-internals flag in the tests.

Refs: #35496

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2020
@aduh95 aduh95 mentioned this pull request Nov 6, 2020
Closed
4 tasks
@targos targos added dont-land-on-v10.x request-ci Add this label to start a Jenkins CI on a PR. labels Nov 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34156/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2020
@aduh95
test: use global.EventTarget instead of internals
36fbbe0 
`EventTarget` is exposed on the global scope, there is no need to use
`--expose-internals` flag in the tests.

Refs: nodejs#35496

PR-URL: nodejs#36002
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 9, 2020

Landed in 36fbbe0

@aduh95 aduh95 merged commit 36fbbe0 into nodejs:master Nov 9, 2020
@aduh95 aduh95 deleted the test-global-eventtarget branch November 9, 2020 18:26
danielleadams pushed a commit that referenced this pull request Nov 10, 2020
@aduh95 @danielleadams
test: use global.EventTarget instead of internals
0a4c96a 
`EventTarget` is exposed on the global scope, there is no need to use
`--expose-internals` flag in the tests.

Refs: #35496

PR-URL: #36002
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @benjamingr @targos