crypto: fix comment in ByteSource #35972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
c++
danbev
approved these changes
Nov 5, 2020
himself65
approved these changes
Nov 5, 2020
devnexen
approved these changes
Nov 5, 2020
gengjiawen
approved these changes
Nov 5, 2020
rickyes
approved these changes
Nov 5, 2020
rickyes
added
the
author ready
|
Feel free to approve fast-tracking by adding 👍 on this comment. |
github-actions
bot
removed
the
request-ci
Trott
approved these changes
Nov 5, 2020
lpinca
approved these changes
Nov 5, 2020
lpinca
pushed a commit
that referenced
this pull request
Nov 5, 2020
PR-URL: #35972 Refs: #35821 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in c9e3848. |
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
PR-URL: #35972 Refs: #35821 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
tniessen
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allocated_data_must not be anullptrifsize_ > 0.Refs: #35821
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes