Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix incorrect heading level #35965

Closed
wants to merge 1 commit into from
Closed

doc: fix incorrect heading level #35965

wants to merge 1 commit into from

Conversation

700software
Copy link
Contributor

image

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. labels Nov 4, 2020
@addaleax
Copy link
Member

addaleax commented Nov 4, 2020

👍 to approve fast-tracking

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 4, 2020
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 4, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

Landed in 8caa6a9...d4d6dfd

@github-actions github-actions bot closed this Nov 4, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 4, 2020
@700software @nodejs-github-bot
doc: fix incorrect heading level
d4d6dfd 
PR-URL: #35965
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@700software @danielleadams
doc: fix incorrect heading level
efbfeff 
PR-URL: #35965
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@700software @targos
doc: fix incorrect heading level
34d8a64 
PR-URL: #35965
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@700software @nodejs-github-bot @addaleax @lpinca @cjihrig @richardlau @aduh95