Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor to use more primordials #35875

Merged
merged 1 commit into from
Nov 5, 2020
Merged

lib: refactor to use more primordials #35875

merged 1 commit into from
Nov 5, 2020

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 29, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 29, 2020
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 30, 2020 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33958/ ✅

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 30, 2020
@aduh95 aduh95 mentioned this pull request Nov 1, 2020
Closed
2 tasks
@aduh95 aduh95 added the review wanted PRs that need reviews. label Nov 1, 2020
@aduh95
lib: refactor to use more primordials
c723e4c 
PR-URL: nodejs#35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 force-pushed the v8-proc-processor-primordials branch from 8d380c1 to c723e4c Compare November 5, 2020 22:16
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 5, 2020

Landed in c723e4c

@aduh95 aduh95 merged commit c723e4c into nodejs:master Nov 5, 2020
@aduh95 aduh95 deleted the v8-proc-processor-primordials branch November 5, 2020 22:16
danielleadams pushed a commit that referenced this pull request Nov 9, 2020
@aduh95 @danielleadams
lib: refactor to use more primordials
b700900 
PR-URL: #35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Nov 9, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@aduh95 @BethGriggs
lib: refactor to use more primordials
6e43da4 
PR-URL: #35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@aduh95 @BethGriggs
lib: refactor to use more primordials
576288b 
PR-URL: #35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@aduh95 @BethGriggs
lib: refactor to use more primordials
de3c804 
PR-URL: #35875
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduh95 @nodejs-github-bot @Trott