Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update crypto.createSecretKey history #35874

Merged
merged 1 commit into from
Nov 1, 2020
Merged

docs: update crypto.createSecretKey history #35874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: update crypto.createSecretKey history 
Passing strings to `crypto.createSecretKey` was not added until v15.0.0
(specifically with commit dae283d). The existing documentation implies
its availability in prior versions which may cause confusion.

PR-URL: #35874
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
@ben-turner @Trott
ben-turner authored and Trott committed Nov 1, 2020
commit 09af8c822c8e931b29427aaec72604ab03fa54c1
5 changes: 3 additions & 2 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2147,8 +2147,9 @@ added: v11.6.0
changes:
- version: v15.0.0
pr-url: https://github.com/nodejs/node/pull/35093
description: The key can also be an ArrayBuffer. The encoding argument was
added. The key cannot contain more than 2 ** 32 - 1 bytes.
description: The key can also be an ArrayBuffer or string. The encoding
argument was added. The key cannot contain more than
2 ** 32 - 1 bytes.
-->

* `key` {string|ArrayBuffer|Buffer|TypedArray|DataView}
Expand Down