-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: edit cpplint.py #35516
tools: edit cpplint.py #35516
Conversation
* Remove unnecessary setting of classinfo where it is set again before it is used. * Change whitelisted_functions to allowed_functions.
Are we ever likely to sync this with upstream? The last time we did was #27098 and it looks like |
It's also gone from https://github.com/google/styleguide/blob/gh-pages/cpplint/cpplint.py, if we want to sync from that upstream instead. (I don't know the relationship between the two other than that one is a fork of the other on GitHub.) |
The superfluous |
Me neither, but whatever we decide to sync from I'd like to keep the number of floating patches we have to maintain to a minimum. |
My vote would be https://github.com/cpplint/cpplint -- I have made contributions there in the past and it has gone quite smoothly. It is 300+ commits ahead of the other and only 7 commits behind. |
This will probably be supplanted by #35569 and a follow-on PR to that, so I'll move this to draft for now, and close it when the relevant changes have landed to make this obsolete. |
it is used.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes