Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2,tls: store WriteWrap using BaseObjectPtr #35488

Closed
wants to merge 2 commits into from

Commits on Oct 3, 2020

  1. http2,tls: store WriteWrap using BaseObjectPtr

    Create weak `WriteWrap` and `ShutdownWrap` objects, and when
    referencing them in C++ is necessary, use `BaseObjectPtr<>`
    instead of plain pointers to keep these objects from being
    garbage-collected.
    
    This solves issues that arise when the underlying `StreamBase`
    instance is weak, but the `WriteWrap` or `ShutdownWrap` instances
    are not; in that case, they would otherwise potentially stick
    around in memory after the stream that they originally belong
    to is long gone.
    
    It probably makes sense to use `BaseObjectptr<>` more extensively
    in `StreamBase` in the long run as well.
    addaleax committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    9abc570 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Configuration menu
    Copy the full SHA
    9cbdbc8 View commit details
    Browse the repository at this point in the history