doc: Revert refine conditions constraints PR#35357
Closed
guybedford wants to merge 1 commit intonodejs:masterfrom
Closed
doc: Revert refine conditions constraints PR#35357guybedford wants to merge 1 commit intonodejs:masterfrom
guybedford wants to merge 1 commit intonodejs:masterfrom
Conversation
This reverts commit 226b186.
Collaborator
|
Review requested:
|
3 tasks
Member
|
I'd prefer we leave it rather than revert. It's a doc change. If someone doesn't like it, they can change it again.... |
Contributor
Author
|
I'm happy either way here and apologies for the mix up. |
Member
|
I'm going to optimistically close this, but any other collaborator who feels differently should absolutely feel free to mash the "re-open" button. |
Contributor
Author
|
That seems a safe assessment to me. There was modules repo discussion on this topic that led to suggestions for the original PR. There were no complaints raised in that discussion for this approach and I don't know of any arguments against the changes in the PR - it was a fairly uncontroversial one I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the PR #35311 which landed before the 7 day limit required for PRs with one approval.
This was a misinterpretation from my side of the previous relaxation of the waiting period, which I thought had also been applied to these cases.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes