Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fixup lutimes metadata #35328

Closed
wants to merge 1 commit into from
Closed

doc: fixup lutimes metadata #35328

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #35320 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Sep 24, 2020
@addaleax
Copy link
Member Author

Please 👍 this to approve fast-tracking

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 24, 2020
@addaleax addaleax mentioned this pull request Sep 24, 2020
Closed
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2020
@github-actions
Copy link
Contributor

Landed in 785a5f9

nodejs-github-bot pushed a commit that referenced this pull request Sep 24, 2020
@addaleax @nodejs-github-bot
doc: fixup lutimes metadata
785a5f9 
Refs: #35320 (comment)

PR-URL: #35328
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot closed this Sep 24, 2020
@addaleax addaleax deleted the doc-lutimes-meta branch September 24, 2020 21:14
MylesBorins pushed a commit that referenced this pull request Sep 29, 2020
@addaleax @MylesBorins
doc: fixup lutimes metadata
dd53036 
Refs: #35320 (comment)

PR-URL: #35328
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 29, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@addaleax @joesepi
doc: fixup lutimes metadata
c2518ab 
Refs: nodejs#35320 (comment)

PR-URL: nodejs#35328
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @lpinca @targos @cjihrig @richardlau @nodejs-github-bot