Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: change 'be will' to 'will be' #34999

Closed
wants to merge 1 commit into from
Closed

doc: change 'be will' to 'will be' #34999

wants to merge 1 commit into from

Conversation

zombieleet
Copy link
Contributor

@zombieleet zombieleet commented Aug 31, 2020 •
edited
Loading

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Aug 31, 2020
cjihrig
cjihrig approved these changes Aug 31, 2020
View reviewed changes
doc/api/events.md
@@ -1102,7 +1102,7 @@ In either case, the handler function will be invoked with the `event` argument
passed to the `eventTarget.dispatchEvent()` function.

Async functions may be used as event listeners. If an async handler function
rejects, the rejection will be captured and be will handled as described in
rejects, the rejection will be captured and will be handled as described in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative (optional) suggestion to avoid double "will be"s:

Suggested change
rejects, the rejection will be captured and will be handled as described in
rejects, the rejection will be captured and handled as described in

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 2, 2020
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2020

Commit Queue failed
- Loading data for nodejs/node/pull/34999
✔  Done loading data for nodejs/node/pull/34999
----------------------------------- PR info ------------------------------------
Title      doc: change 'be will' to 'will be' (#34999)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     zombieleet:patch-2 -> nodejs:master
Labels     author ready, doc, events
Commits    1
 - change 'be will' to 'will be'
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/34999
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Harshitha K P 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/34999
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Harshitha K P 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ✔  Last GitHub Actions successful
   ℹ  Doc-only changes
   ℹ  This PR was created on Mon, 31 Aug 2020 19:54:01 GMT
   ✔  Approvals: 6
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/34999#pullrequestreview-478915711
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/34999#pullrequestreview-478932488
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/34999#pullrequestreview-479397513
   ✔  - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/34999#pullrequestreview-479401980
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/34999#pullrequestreview-480710901
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/34999#pullrequestreview-480858462
--------------------------------------------------------------------------------
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch              master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 34999
✔  Downloaded patch to /home/runner/work/node/node/.ncu/34999/patch
--------------------------------------------------------------------------------
Applying: change 'be will' to 'will be'
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
change 'be will' to 'will be'

PR-URL: #34999

Reviewed-By: Richard Lau riclau@uk.ibm.com

Reviewed-By: Colin Ihrig cjihrig@gmail.com

Reviewed-By: Gireesh Punathil gpunathi@in.ibm.com

Reviewed-By: Harshitha K P harshitha014@gmail.com

Reviewed-By: Anna Henningsen anna@addaleax.net

Reviewed-By: Rich Trott rtrott@gmail.com


[master 8a9187be] change 'be will' to 'will be'

Author: Victory Osikwemhe zombieleetnca@gmail.com

Date: Mon Aug 31 19:52:20 2020 +0000

1 file changed, 1 insertion(+), 1 deletion(-)

✖  8a9187be8d230a79342f8a5712ae836a20b24892

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Missing subsystem.                        subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length


ℹ  Please fix the commit message and try again.

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2020
addaleax pushed a commit that referenced this pull request Sep 5, 2020
@zombieleet @addaleax
doc: change 'be will' to 'will be'
3b54d0d 
PR-URL: #34999
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax
Copy link
Member

addaleax commented Sep 5, 2020

Landed in 3b54d0d

@addaleax addaleax closed this Sep 5, 2020
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@zombieleet @richardlau
doc: change 'be will' to 'will be'
7f20c57 
PR-URL: #34999
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@zombieleet @richardlau
doc: change 'be will' to 'will be'
a846a9f 
PR-URL: #34999
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@zombieleet @joesepi
doc: change 'be will' to 'will be'
b00d603 
PR-URL: nodejs#34999
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@zombieleet @addaleax @Trott @cjihrig @richardlau @gireeshpunathil @HarshithaKP @targos @nodejs-github-bot