Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x backport] stream: simpler and faster Readable async iterator #34887

Closed
wants to merge 6 commits into from
Closed

[v14.x backport] stream: simpler and faster Readable async iterator #34887

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ddca286
stream: simpler and faster Readable async iterator
ronag Oct 10, 2020
474eaea
fixup
ronag Oct 14, 2020
2965f61
fixup
ronag Oct 14, 2020
ba13815
fixup
ronag Oct 14, 2020
23237c2
fixup
ronag Oct 14, 2020
c1b028c
fixup
ronag Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ronag
ronag committed Oct 14, 2020
commit 23237c294f38c523987ce16a73d2bf46f8a290de
4 changes: 2 additions & 2 deletions test/parallel/test-stream-readable-async-iterators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,14 +712,14 @@ async function tests() {
_req = http.request(`http://localhost:${server.address().port}`)
.on('response', common.mustCall(async (res) => {
setTimeout(() => {
res.destroy(new Error('something happened'));
_req.destroy(new Error('something happened'));
}, 100);

res.on('aborted', () => {
const err = new Error();
err.code = 'ECONNRESET';
res.emit('error', err);
})
});

res.on('error', common.mustCall());

Expand Down