Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-cluster-net-listen-relative-path.js to run in / #34820

Merged
merged 7 commits into from
Aug 20, 2020
Merged

test: fix test-cluster-net-listen-relative-path.js to run in / #34820

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5acc69c
doc: move addaleax to TSC emeritus
addaleax Aug 17, 2020
03293aa
build,win: use x64 Node when building for ARM64
dennisameling Jun 22, 2020
de565ad
process: correctly parse Unicode in NODE_OPTIONS
bzoz Jul 22, 2020
6130cdd
test: run REPL preview test regardless of terminal type
Trott Aug 16, 2020
9d81d12
doc: sort references lexically
Trott Aug 20, 2020
9fd71a9
doc: fix bulleted list punctuation in BUILDING.md
Trott Aug 20, 2020
796317f
test: fix test-cluster-net-listen-relative-path.js to run in /
Trott Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix bulleted list punctuation in BUILDING.md 
Remove/add periods as appropriate in bulleted lists in BUILDING.md.

PR-URL: #34849
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
  • Loading branch information
@Trott
Trott committed Aug 20, 2020
commit 9fd71a9964a9fdfd3647ae99097e10df634bb1ed
12 changes: 6 additions & 6 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ test with Python 3.
* GNU Make 3.81 or newer
* Python (see note above)
* Python 2.7
* Python 3.5, 3.6, 3.7, and 3.8.
* Python 3.5, 3.6, 3.7, and 3.8

Installation via Linux package manager can be achieved with:

Expand All @@ -256,7 +256,7 @@ Python 3 users may also need to install `python3-distutils`.
* Xcode Command Line Tools >= 10 for macOS
* Python (see note above)
* Python 2.7
* Python 3.5, 3.6, 3.7, and 3.8.
* Python 3.5, 3.6, 3.7, and 3.8

macOS users can install the `Xcode Command Line Tools` by running
`xcode-select --install`. Alternatively, if you already have the full Xcode
Expand Down Expand Up @@ -531,7 +531,7 @@ to run it again before invoking `make -j4`.
[Visual Studio 2019](https://visualstudio.microsoft.com/downloads/) or
the "Visual C++ build tools" workload from the
[Build Tools](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019),
with the default optional components.
with the default optional components
* Basic Unix tools required for some tests,
[Git for Windows](https://git-scm.com/download/win) includes Git Bash
and tools which can be included in the global `PATH`.
Expand All @@ -543,9 +543,9 @@ to run it again before invoking `make -j4`.
Optional requirements to build the MSI installer package:

* The [WiX Toolset v3.11](https://wixtoolset.org/releases/) and the
[Wix Toolset Visual Studio 2019 Extension](https://marketplace.visualstudio.com/items?itemName=WixToolset.WixToolsetVisualStudio2019Extension).
[Wix Toolset Visual Studio 2019 Extension](https://marketplace.visualstudio.com/items?itemName=WixToolset.WixToolsetVisualStudio2019Extension)
* The [WiX Toolset v3.14](https://wixtoolset.org/releases/) if
building for Windows 10 on ARM (ARM64).
building for Windows 10 on ARM (ARM64)

Optional requirements for compiling for Windows 10 on ARM (ARM64):

Expand All @@ -563,7 +563,7 @@ This script will install the following [Chocolatey](https://chocolatey.org/)
packages:

* [Git for Windows](https://chocolatey.org/packages/git) with the `git` and
Unix tools added to the `PATH`.
Unix tools added to the `PATH`
* [Python 3.x](https://chocolatey.org/packages/python) and
[legacy Python](https://chocolatey.org/packages/python2)
* [Visual Studio 2019 Build Tools](https://chocolatey.org/packages/visualstudio2019buildtools)
Expand Down