-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove "is recommended" from crypto legacy API text #34697
Commits on Aug 17, 2020
-
http2: allow Host in HTTP/2 requests
The HTTP/2 spec allows Host to be used instead of :authority in requests, and this is in fact *preferred* when converting from HTTP/1. We erroneously treated Host as a connection header, thus disallowing it in requests. The patch corrects this, aligning Node.js behaviour with the HTTP/2 spec and with nghttp2: - Treat Host as a single-value header instead of a connection header. - Don't autofill :authority if Host is present. - The compatibility API (request.authority) falls back to using Host if :authority is not present. This is semver-major because requests are no longer guaranteed to have :authority set. An explanatory note was added to the docs. Fixes: nodejs#29858 PR-URL: nodejs#34664 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f5c0e28 - Browse repository at this point
Copy the full SHA f5c0e28View commit details -
http2: use and support non-empty DATA frame with END_STREAM flag
Adds support for reading from a stream where the final frame is a non-empty DATA frame with the END_STREAM flag set, instead of hanging waiting for another frame. When writing to a stream, uses a END_STREAM flag on final DATA frame instead of adding an empty DATA frame. BREAKING: http2 client now expects servers to properly support END_STREAM flag Fixes: nodejs#31309 Fixes: nodejs#33891 Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback PR-URL: nodejs#33875 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0e30c5b - Browse repository at this point
Copy the full SHA 0e30c5bView commit details -
doc: fix broken links in commit-queue.md
Fixes: nodejs#34787 PR-URL: nodejs#34789 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Configuration menu - View commit details
-
Copy full SHA for 92167e2 - Browse repository at this point
Copy the full SHA 92167e2View commit details -
build: add CODEOWNERS linter action
PR-URL: nodejs#34739 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Configuration menu - View commit details
-
Copy full SHA for 8b818cf - Browse repository at this point
Copy the full SHA 8b818cfView commit details -
quic: resolve minor TODO in QuicSocket
PR-URL: nodejs#34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1e6e5c3 - Browse repository at this point
Copy the full SHA 1e6e5c3View commit details -
quic: resolve some minor TODOs
PR-URL: nodejs#34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 34165f0 - Browse repository at this point
Copy the full SHA 34165f0View commit details -
quic: limit push check to http/3
PR-URL: nodejs#34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 344c5e4 - Browse repository at this point
Copy the full SHA 344c5e4View commit details -
quic: fixup set_socket, fix skipped test
PR-URL: nodejs#34669 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 10d5047 - Browse repository at this point
Copy the full SHA 10d5047View commit details -
quic: check setSocket natRebinding argument, extend test
PR-URL: nodejs#34669 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 442968c - Browse repository at this point
Copy the full SHA 442968cView commit details -
quic: add natRebinding argument to docs
PR-URL: nodejs#34669 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for c17eaa3 - Browse repository at this point
Copy the full SHA c17eaa3View commit details -
quic: fixup session ticket app data todo comments
PR-URL: nodejs#34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2405922 - Browse repository at this point
Copy the full SHA 2405922View commit details -
quic: resolve InitializeSecureContext TODO comment
Using a static label is sufficient. PR-URL: nodejs#34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 19e712b - Browse repository at this point
Copy the full SHA 19e712bView commit details -
PR-URL: nodejs#34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 94aa291 - Browse repository at this point
Copy the full SHA 94aa291View commit details -
quic: consolidate stats collecting in QuicSession
PR-URL: nodejs#34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bfc3535 - Browse repository at this point
Copy the full SHA bfc3535View commit details -
src: allow instances of net.BlockList to be created internally
Initial PR had it so that user code would create BlockList instances. This sets it up so that instances can be created internally by Node.js PR-URL: nodejs#34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1c14810 - Browse repository at this point
Copy the full SHA 1c14810View commit details -
quic: use net.BlockList for limiting access to a QuicSocket
PR-URL: nodejs#34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c855c3e - Browse repository at this point
Copy the full SHA c855c3eView commit details -
meta: fix codeowners docs path
s/docs/doc/g Signed-off-by: Mary Marchini <mmarchini@netflix.com> PR-URL: nodejs#34811 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5835367 - Browse repository at this point
Copy the full SHA 5835367View commit details -
worker: do not crash when JSTransferable lists untransferable value
This can currently be triggered when posting a closing FileHandle. Refs: nodejs#34746 (comment) PR-URL: nodejs#34766 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 81df668 - Browse repository at this point
Copy the full SHA 81df668View commit details -
Update ESLint to 7.7.0 PR-URL: nodejs#34783 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0eca660 - Browse repository at this point
Copy the full SHA 0eca660View commit details -
doc: edit filehandle.close() entry in fs.md
PR-URL: nodejs#34782 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for c62cf1d - Browse repository at this point
Copy the full SHA c62cf1dView commit details -
lib: allow to validate enums with validateOneOf
PR-URL: nodejs#34070 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6726246 - Browse repository at this point
Copy the full SHA 6726246View commit details
Commits on Aug 18, 2020
-
doc,lib: remove unused error code
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our code base and dependencies. Move to legacy errors. PR-URL: nodejs#34792 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 15fdd98 - Browse repository at this point
Copy the full SHA 15fdd98View commit details -
test: convert assertion that always fails to assert.fail()
In test-http-destroyed-socket-write2, the assert.strictEqual() in the default case of the switch statement will always fail because it checks for a value that is already accounted for in one of the switch cases. Convert it to assert.fail(). PR-URL: nodejs#34793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aa5361c - Browse repository at this point
Copy the full SHA aa5361cView commit details -
doc: remove "is recommended from crypto legacy API text
The text for the legacy API sends mixed signals. It's legacy, but still supported, so not deprecated, but not recommended. Let's begin to clarify this by removing "not recommended". If we want to not-recommend it, let's doc-deprecate it properly, or at least include an explanation as to why it's not recommended. PR-URL: nodejs#34697 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 60d572c - Browse repository at this point
Copy the full SHA 60d572cView commit details -
doc: deprecate (doc-only) crypto.Certificate()
Documentation-only: Recommend people use the static methods on crypto.Certificate() and not the legacy API constructor. PR-URL: nodejs#34697 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for ca5ff72 - Browse repository at this point
Copy the full SHA ca5ff72View commit details