Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove "is recommended" from crypto legacy API text #34697

Merged
merged 25 commits into from
Aug 18, 2020

Commits on Aug 17, 2020

  1. http2: allow Host in HTTP/2 requests

    The HTTP/2 spec allows Host to be used instead of :authority in
    requests, and this is in fact *preferred* when converting from HTTP/1.
    
    We erroneously treated Host as a connection header, thus disallowing
    it in requests. The patch corrects this, aligning Node.js behaviour
    with the HTTP/2 spec and with nghttp2:
    
     - Treat Host as a single-value header instead of a connection header.
     - Don't autofill :authority if Host is present.
     - The compatibility API (request.authority) falls back to using Host
       if :authority is not present.
    
    This is semver-major because requests are no longer guaranteed to
    have :authority set. An explanatory note was added to the docs.
    
    Fixes: nodejs#29858
    
    PR-URL: nodejs#34664
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    mildsunrise committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    f5c0e28 View commit details
    Browse the repository at this point in the history
  2. http2: use and support non-empty DATA frame with END_STREAM flag

    Adds support for reading from a stream where the final frame is a
    non-empty DATA frame with the END_STREAM flag set, instead of hanging
    waiting for another frame. When writing to a stream, uses a
    END_STREAM flag on final DATA frame instead of adding an empty
    DATA frame.
    
    BREAKING: http2 client now expects servers to properly support
    END_STREAM flag
    
    Fixes: nodejs#31309
    Fixes: nodejs#33891
    Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback
    
    PR-URL: nodejs#33875
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    clshortfuse authored and addaleax committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    0e30c5b View commit details
    Browse the repository at this point in the history
  3. doc: fix broken links in commit-queue.md

    Fixes: nodejs#34787
    
    PR-URL: nodejs#34789
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Mary Marchini <oss@mmarchini.me>
    lpinca authored and mmarchini committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    92167e2 View commit details
    Browse the repository at this point in the history
  4. build: add CODEOWNERS linter action

    PR-URL: nodejs#34739
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mmarchini committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    8b818cf View commit details
    Browse the repository at this point in the history
  5. quic: resolve minor TODO in QuicSocket

    PR-URL: nodejs#34655
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    1e6e5c3 View commit details
    Browse the repository at this point in the history
  6. quic: resolve some minor TODOs

    PR-URL: nodejs#34655
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    34165f0 View commit details
    Browse the repository at this point in the history
  7. quic: limit push check to http/3

    PR-URL: nodejs#34655
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    344c5e4 View commit details
    Browse the repository at this point in the history
  8. quic: fixup set_socket, fix skipped test

    PR-URL: nodejs#34669
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    10d5047 View commit details
    Browse the repository at this point in the history
  9. quic: check setSocket natRebinding argument, extend test

    PR-URL: nodejs#34669
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    442968c View commit details
    Browse the repository at this point in the history
  10. quic: add natRebinding argument to docs

    PR-URL: nodejs#34669
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c17eaa3 View commit details
    Browse the repository at this point in the history
  11. quic: fixup session ticket app data todo comments

    PR-URL: nodejs#34741
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    2405922 View commit details
    Browse the repository at this point in the history
  12. quic: resolve InitializeSecureContext TODO comment

    Using a static label is sufficient.
    
    PR-URL: nodejs#34741
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    19e712b View commit details
    Browse the repository at this point in the history
  13. quic: clarify TODO statements

    PR-URL: nodejs#34741
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    94aa291 View commit details
    Browse the repository at this point in the history
  14. quic: consolidate stats collecting in QuicSession

    PR-URL: nodejs#34741
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    bfc3535 View commit details
    Browse the repository at this point in the history
  15. src: allow instances of net.BlockList to be created internally

    Initial PR had it so that user code would create BlockList
    instances. This sets it up so that instances can be created
    internally by Node.js
    
    PR-URL: nodejs#34741
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    1c14810 View commit details
    Browse the repository at this point in the history
  16. quic: use net.BlockList for limiting access to a QuicSocket

    PR-URL: nodejs#34741
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c855c3e View commit details
    Browse the repository at this point in the history
  17. meta: fix codeowners docs path

    s/docs/doc/g
    Signed-off-by: Mary Marchini <mmarchini@netflix.com>
    
    PR-URL: nodejs#34811
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    mmarchini committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    5835367 View commit details
    Browse the repository at this point in the history
  18. worker: do not crash when JSTransferable lists untransferable value

    This can currently be triggered when posting a closing FileHandle.
    
    Refs: nodejs#34746 (comment)
    
    PR-URL: nodejs#34766
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    81df668 View commit details
    Browse the repository at this point in the history
  19. tools: update ESLint to 7.7.0

    Update ESLint to 7.7.0
    
    PR-URL: nodejs#34783
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    0eca660 View commit details
    Browse the repository at this point in the history
  20. doc: edit filehandle.close() entry in fs.md

    PR-URL: nodejs#34782
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    c62cf1d View commit details
    Browse the repository at this point in the history
  21. lib: allow to validate enums with validateOneOf

    PR-URL: nodejs#34070
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    lundibundi authored and jasnell committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    6726246 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2020

  1. doc,lib: remove unused error code

    As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our
    code base and dependencies. Move to legacy errors.
    
    PR-URL: nodejs#34792
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    15fdd98 View commit details
    Browse the repository at this point in the history
  2. test: convert assertion that always fails to assert.fail()

    In test-http-destroyed-socket-write2, the assert.strictEqual() in the
    default case of the switch statement will always fail because it checks
    for a value that is already accounted for in one of the switch cases.
    Convert it to assert.fail().
    
    PR-URL: nodejs#34793
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    aa5361c View commit details
    Browse the repository at this point in the history
  3. doc: remove "is recommended from crypto legacy API text

    The text for the legacy API sends mixed signals. It's legacy, but still
    supported, so not deprecated, but not recommended. Let's begin to
    clarify this by removing "not recommended". If we want to not-recommend
    it, let's doc-deprecate it properly, or at least include an explanation
    as to why it's not recommended.
    
    PR-URL: nodejs#34697
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    60d572c View commit details
    Browse the repository at this point in the history
  4. doc: deprecate (doc-only) crypto.Certificate()

    Documentation-only: Recommend people use the static methods on
    crypto.Certificate() and not the legacy API constructor.
    
    PR-URL: nodejs#34697
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    ca5ff72 View commit details
    Browse the repository at this point in the history