Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: set SA_SIGINFO flag when using sa_sigaction #34648

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

src: set SA_SIGINFO flag when using sa_sigaction #34648

wants to merge 2 commits into from

Conversation

richardlau
Copy link
Member

For sigaction() the SA_SIGINFO flag should be set when setting
the handler via the sa_sigaction member of the sigaction struct.

This unfortunately doesn't fix #34410 but AFAICT looks correct based
on the sigaction() docs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 6, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
addaleax
addaleax reviewed Aug 6, 2020
View reviewed changes
src/node.cc Outdated Show resolved Hide resolved
@richardlau
src: set SA_SIGINFO flag when using sa_sigaction
517a93d 
For `sigaction()` the `SA_SIGINFO` flag should be set when setting
the handler via the `sa_sigaction` member of the `sigaction` struct.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
jasnell
jasnell reviewed Aug 6, 2020
View reviewed changes
src/node.cc Outdated Show resolved Hide resolved
@richardlau @jasnell
fixup! src: set SA_SIGINFO flag when using sa_sigaction
f594659 
Co-authored-by: James M Snell <jasnell@gmail.com>
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32657/

@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 6, 2020
This was referenced Aug 7, 2020
Open
Open
@richardlau
Copy link
Member Author

So I'm not sure why but it looks like on AIX if reset_handler is set then all members of the siginfo argument passed to the handler are 0. @nodejs/platform-aix any ideas?

@richardlau
Copy link
Member Author

So I'm not sure why but it looks like on AIX if reset_handler is set then all members of the siginfo argument passed to the handler are 0. @nodejs/platform-aix any ideas?

FWIW I've distilled the problem down to https://github.com/richardlau/signals

This was referenced Aug 8, 2020
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 12, 2020
Open
Open
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34196/

@gireeshpunathil gireeshpunathil mentioned this pull request Jan 17, 2023
Closed
@aduh95
Copy link
Contributor

aduh95 commented May 5, 2024

This needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addons/register-signal-handler/test and abort/test-addon-register-signal-handler failed
6 participants
@richardlau @nodejs-github-bot @aduh95 @fhinkel @jasnell @addaleax