test: split test-crypto-dh-hash #34631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Aug 5, 2020
Member
Author
|
Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15750/ (:green_heart:) |
Trott
added
the
author ready
targos
approved these changes
Aug 11, 2020
Member
Author
|
Landed in bbfb014 |
Trott
added a commit
that referenced
this pull request
Aug 11, 2020
test-crypto-dh-hash times out on some platforms. A single test case is responsible for around 50% of the time to run, so split that test case into its own file. PR-URL: #34631 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2020
test-crypto-dh-hash times out on some platforms. A single test case is responsible for around 50% of the time to run, so split that test case into its own file. PR-URL: #34631 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
test-crypto-dh-hash times out on some platforms. A single test case is responsible for around 50% of the time to run, so split that test case into its own file. PR-URL: #34631 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
test-crypto-dh-hash times out on some platforms. A single test case is responsible for around 50% of the time to run, so split that test case into its own file. PR-URL: #34631 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
test-crypto-dh-hash times out on some platforms. A single test case is responsible for around 50% of the time to run, so split that test case into its own file. PR-URL: #34631 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Jul 18, 2022
This test file was split because it was taking a long time in some versions of OpenSSL 1.1.1, but that is not the case anymore with OpenSSL 3.0, so merge the tests again. Refs: nodejs#34631
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Jul 18, 2022
This test file was split because it was taking a long time in some versions of OpenSSL 1.1.1, but that is not the case anymore with OpenSSL 3.0, so merge the tests again. Refs: nodejs#34631
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
This test file was split because it was taking a long time in some versions of OpenSSL 1.1.1, but that is not the case anymore with OpenSSL 3.0, so merge the tests again. Refs: nodejs#34631 PR-URL: nodejs#43891 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-crypto-dh-hash times out on some platforms. A single test case is
responsible for around 50% of the time to run, so split that test case
into its own file.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes