Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: wrap assert.fail when passed to callback #3453

Closed
wants to merge 1 commit into from
Closed

test: wrap assert.fail when passed to callback #3453

wants to merge 1 commit into from

Commits on Oct 23, 2015

  1. test: wrap assert.fail when passed to callback 

    Currently there are many instances where assert.fail is directly passed
to a callback for error handling. Unfortunately this will swallow the
error as it is the third argument of assert.fail that sets the message
not the first.

This commit adds a new function to test/common.js that simply wraps
assert.fail and calls it with the provided message.

Tip of the hat to @Trott for pointing me in the direction of this.
    @MylesBorins
    Myles Borins authored and MylesBorins committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    f5d9d37 View commit details
    Browse the repository at this point in the history