tls: remove setMaxSendFragment guards#34323
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
tniessen
added
tls
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Jul 14, 2020
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Unless we still support 1.0.2, even though it is at EOL?
We don't so no problem there.
jasnell
approved these changes
Jul 14, 2020
Collaborator
tniessen
added
the
author ready
tniessen
added a commit
that referenced
this pull request
Jul 19, 2020
Refs: nodejs/node-v0.x-archive#6900 Refs: nodejs/node-v0.x-archive#6889 PR-URL: #34323 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in e3f8dc1, thank you for reviewing. |
tniessen
removed
the
author ready
cjihrig
pushed a commit
that referenced
this pull request
Jul 23, 2020
Refs: nodejs/node-v0.x-archive#6900 Refs: nodejs/node-v0.x-archive#6889 PR-URL: #34323 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 27, 2020
Refs: nodejs/node-v0.x-archive#6900 Refs: nodejs/node-v0.x-archive#6889 PR-URL: #34323 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Refs: nodejs/node-v0.x-archive#6900 Refs: nodejs/node-v0.x-archive#6889 PR-URL: #34323 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Refs: nodejs/node-v0.x-archive#6900 Refs: nodejs/node-v0.x-archive#6889 PR-URL: #34323 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoringSSL implements
SSL_set_max_send_fragmentas a function, while OpenSSL implements it as a macro. I can't test it right now, but I suspect that callingsetMaxSendFragmentin Electron throws (maybe @codebytere can confirm?). AFAICT, all current OpenSSL versions have the macro, so removing these guards should not break anything. (Unless we still support 1.0.2, even though it is at EOL?)Refs: nodejs/node-v0.x-archive#6900
Refs: nodejs/node-v0.x-archive#6889
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes