Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise text in dns module documentation introduction #33986

Merged
merged 20 commits into from
Jun 22, 2020
Merged

Commits on Jun 21, 2020

  1. http: don't emit error after close

    Refs: nodejs#33591
    
    PR-URL: nodejs#33654
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ronag committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    30cc542 View commit details
    Browse the repository at this point in the history
  2. fs: document why isPerformingIO is required

    PR-URL: nodejs#33982
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ronag committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    51a2df4 View commit details
    Browse the repository at this point in the history
  3. timers: fix multipleResolves in promisified timeouts/immediates

    After successful timer finish the abort event callback would still
    reject (already resolved promise) upon calling abortController.abort().
    
    Signed-off-by: Denys Otrishko <shishugi@gmail.com>
    
    PR-URL: nodejs#33949
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    lundibundi authored and ronag committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    64d22c3 View commit details
    Browse the repository at this point in the history
  4. http: add maxTotalSockets to agent class

    Add maxTotalSockets to determine how many sockets an agent can open.
    Unlike maxSockets, The maxTotalSockets does not count by per origin.
    
    PR-URL: nodejs#33617
    Fixes: nodejs#31942
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    rickyes authored and ronag committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    7a5d3a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. doc: use Class: consistently

    The docs contain 122 uses of `Class:` in headers and one use of `class:`
    in headers. This changes that one instance to conform with the other
    instances.
    
    PR-URL: nodejs#33978
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    3de78ad View commit details
    Browse the repository at this point in the history
  2. doc: change "GitHub Repo" to "Code repository"

    "GitHub Repo & Issue Tracker" changed to "Code repository and issue
    tracker".
    
    PR-URL: nodejs#33985
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matheus Marchini <mat@mmarchini.me>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Trott committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    f05c963 View commit details
    Browse the repository at this point in the history
  3. doc: fix lexical sorting of bottom-references in dns doc

    The links are sorted in lexical order except for the two RFC links which
    are reversed. Fix that.
    
    PR-URL: nodejs#33987
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    07b2ada View commit details
    Browse the repository at this point in the history
  4. build: add target specific build_type variable

    This commit add a target specific variable named 'build_type' to the
    node and node_g targets.
    
    The motivation for doing this is that both targets share the same
    prerequisites, and the recepies are the same (apart from the build type)
    so some duplication can be avoided.
    
    PR-URL: nodejs#33925
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    danbev committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    122038c View commit details
    Browse the repository at this point in the history
  5. src: remove unnecessary ToLocalChecked call

    PR-URL: nodejs#33902
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    danbev committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    54374d4 View commit details
    Browse the repository at this point in the history
  6. doc: warn that tls.connect() doesn't set SNI

    Add a note warning users that when using tls.connect(),
    the `servername` option must be set explicitely to enable
    SNI, otherwise the connection could fail.
    
    PR-URL: nodejs#33855
    Fixes: nodejs#28167
    Co-authored-by: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    mildsunrise and lundibundi committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    b8ea471 View commit details
    Browse the repository at this point in the history
  7. quic: fix typo in comments

    PR-URL: nodejs#33975
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    gengjiawen committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    9743624 View commit details
    Browse the repository at this point in the history
  8. quic: fix clang-tidy performance-faster-string-find issue

    PR-URL: nodejs#33975
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    gengjiawen committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    09330fc View commit details
    Browse the repository at this point in the history
  9. src: improve indention for upd_wrap.cc

    PR-URL: nodejs#33976
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    gengjiawen committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    25413b0 View commit details
    Browse the repository at this point in the history
  10. test: fix typo in common/index.js

    PR-URL: nodejs#33976
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    gengjiawen committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    74cd70e View commit details
    Browse the repository at this point in the history
  11. test: fix typo in test-quic-client-empty-preferred-address.js

    PR-URL: nodejs#33976
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    gengjiawen committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    326a79e View commit details
    Browse the repository at this point in the history
  12. quic: use Check instead of FromJust in node_quic.cc

    PR-URL: nodejs#33937
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    danbev committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    013cd1a View commit details
    Browse the repository at this point in the history
  13. doc: update fs.md

    First class heading is made to look like other headings.
    
    PR-URL: nodejs#33820
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Shakil-Shahadat authored and gireeshpunathil committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    73a7a24 View commit details
    Browse the repository at this point in the history
  14. http: expose host and protocol on ClientRequest

    Allow host and protocol to be inspected.
    
    PR-URL: nodejs#33803
    Fixes: nodejs#2461
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    wenningplus authored and ronag committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    680644a View commit details
    Browse the repository at this point in the history
  15. quic: fix clang warning

    PR-URL: nodejs#33963
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Denys Otrishko <shishugi@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    gengjiawen authored and jasnell committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    8ef86a9 View commit details
    Browse the repository at this point in the history
  16. doc: revise text in dns module documentation introduction

    PR-URL: nodejs#33986
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Trott committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    df144d2 View commit details
    Browse the repository at this point in the history