Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v12.18.1 proposal #33811

Merged
merged 88 commits into from
Jun 17, 2020
Merged
Changes from 1 commit
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
194789f
stream: make all streams error in a pipeline
mcollina Dec 9, 2019
edf75e4
src: use basename(argv0) for --trace-uncaught suggestion
addaleax Apr 12, 2020
1766514
test: add tests for options.fs in fs streams
julianduque May 1, 2020
e572cf9
doc: fix style and grammer in buffer.md
seishun May 1, 2020
c6cf048
doc: explicitly doc package.exports is breaking
MylesBorins Apr 26, 2020
b43fc64
Revert "src: add aliased-buffer-overflow abort test"
richardlau May 1, 2020
c054834
Revert "src: add test/abort build tasks"
richardlau May 1, 2020
ea3a68f
doc: doc and test URLSearchParams discrepancy
jasnell May 4, 2020
033bc96
doc: update napi_async_init documentation
mhdawson Apr 30, 2020
4294d92
stream: make from read one at a time
ronag May 1, 2020
82da74b
n-api: add uint32 test for -1
May 5, 2020
ac5cdd6
doc: add warnings about transferring Buffers and ArrayBuffer
jasnell May 5, 2020
2262962
doc: remove AsyncWrap mentions from async_hooks.md
puzpuzpuz May 5, 2020
ad7a890
doc: add troubleshooting guide for AsyncLocalStorage
puzpuzpuz May 5, 2020
33aacbe
wasi: prevent syscalls before start
tniessen May 4, 2020
4a58420
doc: specify unit of time passed to `fs.utimes`
SimenB May 4, 2020
8b44be9
doc: add Uint8Array to `end` and `write`
rexagod May 2, 2020
9038620
doc: update Buffer(size) documentation
seishun May 1, 2020
0cee4c3
doc: removed unnecessary util imports from vm examples
WalasPrime Apr 30, 2020
59619b0
doc: mention python3-distutils dependency in BUILDING.md
osher Apr 30, 2020
9017bce
lib: fix grammar in internal/bootstrap/loaders.js
szTheory May 2, 2020
139eb6b
test: skip some console tests on dumb terminal
AdamMajer Apr 30, 2020
0177cbf
test: rename test-lookupService-promises
rickyes Apr 27, 2020
0c7cf24
doc: correct description of `decipher.setAuthTag` in crypto.md
jbuhacoff Apr 27, 2020
ed62d43
src: clean up large pages code
May 5, 2020
22f2c2c
wasi: fix poll_oneoff memory interface
cjihrig May 5, 2020
9dde1db
doc: add warning for socket.connect reuse
ronag May 5, 2020
77caf92
module: better error for named exports from cjs
MylesBorins May 5, 2020
a5e8c5c
src: split out callback queue implementation from Environment
addaleax May 6, 2020
6881410
lib: refactored scheduling policy assignment
yashLadha Apr 5, 2020
d64dbfa
meta: add issue template for API reference docs
DerekNonGeneric Apr 20, 2020
642f813
src: fix invalid windowBits=8 gzip segfault
bnoordhuis Apr 24, 2020
631e433
zlib: reject windowBits=8 when mode=GZIP
bnoordhuis Apr 24, 2020
66dbaff
http2: add `bytesWritten` test for `Http2Stream`
rexagod Apr 21, 2020
964adfa
buffer: improve copy() performance
seishun May 2, 2020
4d6f56a
deps: upgrade npm to 6.14.5
ruyadorno May 4, 2020
68551d2
perf_hooks: fix error message for invalid entryTypes
targos May 7, 2020
cd92052
test: add hr-time Web platform tests
targos May 7, 2020
5d5e66c
tools: add eslint rule to only pass through 'test' to debuglog
BridgeAR Mar 9, 2020
cdd7d3a
tools: remove obsolete no-restricted-syntax eslint rules
BridgeAR Mar 9, 2020
b630079
src: remove unnecessary Isolate::GetCurrent() calls
addaleax May 8, 2020
59769c4
lib: fix typo in timers insert function comment
danbev May 8, 2020
2645b1c
tools: update ESLint to 7.0.0
cjihrig May 8, 2020
c459832
test: fix test-net-throttle
Trott May 9, 2020
f27ae6e
src: fix typo in comment in async_wrap.cc
danbev May 11, 2020
30c9cb5
doc: fix typo in n-api.md
danbev May 9, 2020
318fcf8
doc: add note about clientError writable handling
ShogunPanda May 8, 2020
548672d
src: use MaybeLocal.ToLocal instead of IsEmpty
danbev May 8, 2020
82c43d1
src: delete unused variables to resolve compile time print warning
rickyes May 11, 2020
fe780a5
src: remove unused using declarations in node.cc
danbev May 6, 2020
1f159e4
src: add primordials to arguments comment
danbev May 9, 2020
fa16313
test: update WPT interfaces and hr-time
joyeecheung May 12, 2020
33a7878
test: refactor WPTRunner
joyeecheung May 6, 2020
7315c22
tls: fix --tls-keylog option
mildsunrise May 12, 2020
3d8ba29
doc: add examples for implementing ESM
rosaxxny Apr 30, 2020
9f594be
test: fix test-dns-idna2008
Trott May 12, 2020
d2897a2
doc: enhance guides by fixing and making grammar more consistent
ChrisAHolland Apr 29, 2020
aa4611c
fs: clean up Dir.read() uv_fs_t data before calling into JS
addaleax May 6, 2020
c129e88
fs: forbid concurrent operations on Dir handle
addaleax May 7, 2020
8a92698
worker: call CancelTerminateExecution() before exiting Locker
addaleax May 10, 2020
ba93c8d
async_hooks: clear async_id_stack for terminations in more places
addaleax May 11, 2020
5da7d52
test: regression tests for async_hooks + Promise + Worker interaction
addaleax May 10, 2020
a0bc2e3
src: replace to CHECK_NOT_NULL in node_crypto
himself65 May 13, 2020
4f6e4ae
module: add specific error for dir import
aduh95 May 3, 2020
a029dca
esm: improve commonjs hint on module not found
aduh95 May 14, 2020
29d24db
src: add #include <string> in json_utils.h
zcbenz May 10, 2020
b4d9034
worker: fix crash when .unref() is called during exit
addaleax May 14, 2020
b924910
src: distinguish refed/unrefed threadsafe Immediates
addaleax May 9, 2020
a9ed287
doc: fix extension in esm example
devsnek May 14, 2020
e240d56
tools: update dependencies for markdown linting
Trott May 15, 2020
5d80576
errors: skip fatal error highlighting on windows
Hakerh400 Apr 28, 2020
9883ba6
src: add promise_resolve to SetupHooks comment
danbev May 12, 2020
e668376
src: remove unused misc variable
danbev May 15, 2020
548db2e
src: remove unused IsolateSettings variable
danbev May 15, 2020
a48aeb3
doc: clarify about the Node.js-only extensions in perf_hooks
joyeecheung May 1, 2020
402aa1b
deps: upgrade to libuv 1.38.0
cjihrig May 17, 2020
4749156
doc: add comment about highWaterMark limit
benjamingr May 16, 2020
0c9b826
doc: update function description for `decipher.setAAD`
jbuhacoff Apr 27, 2020
c797c7c
src: reduce duplication in RegisterHandleCleanups
danbev May 15, 2020
5eed20b
worker: fix race condition in node_messaging.cc
addaleax May 16, 2020
fa4a37c
http2: comment on usage of `Object.create(null)`
rexagod Apr 25, 2020
7d8a226
doc: fix typos in handle scope descriptions
tniessen May 6, 2020
9572701
doc: add fs.open() multiple constants example
Ethan-Arrowood May 7, 2020
98a7026
doc: document module.path
aduh95 May 9, 2020
e67df04
src: use BaseObjectPtr in StreamReq::Dispose
jasnell Apr 27, 2020
5c7176b
deps: update to uvwasi 0.0.9
cjihrig May 4, 2020
af95bd7
deps: V8: cherry-pick 548f6c81d424
dominykas May 20, 2020
6665f73
2020-06-17, Version 12.18.1 'Erbium' (LTS)
codebytere Jun 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fix style and grammer in buffer.md
PR-URL: #33194
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
seishun authored and codebytere committed Jun 7, 2020
commit e572cf93e562e4cbe44f8f68d5bfeaac2c99089d
13 changes: 7 additions & 6 deletions doc/api/buffer.md
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ Array entries outside that range will be truncated to fit into it.
const buf = Buffer.from([0x62, 0x75, 0x66, 0x66, 0x65, 0x72]);
```

A `TypeError` will be thrown if `array` is not an `Array` or other type
A `TypeError` will be thrown if `array` is not an `Array` or another type
appropriate for `Buffer.from()` variants.

`Buffer.from(array)` and [`Buffer.from(string)`][] may also use the internal
Expand Down Expand Up @@ -623,7 +623,8 @@ console.log(buf.length);
```

A `TypeError` will be thrown if `arrayBuffer` is not an [`ArrayBuffer`][] or a
[`SharedArrayBuffer`][] or other type appropriate for `Buffer.from()` variants.
[`SharedArrayBuffer`][] or another type appropriate for `Buffer.from()`
variants.

### Class Method: `Buffer.from(buffer)`
<!-- YAML
Expand All @@ -647,7 +648,7 @@ console.log(buf2.toString());
// Prints: buffer
```

A `TypeError` will be thrown if `buffer` is not a `Buffer` or other type
A `TypeError` will be thrown if `buffer` is not a `Buffer` or another type
appropriate for `Buffer.from()` variants.

### Class Method: `Buffer.from(object[, offsetOrEncoding[, length]])`
Expand Down Expand Up @@ -684,8 +685,8 @@ const buf = Buffer.from(new Foo(), 'utf8');
// Prints: <Buffer 74 68 69 73 20 69 73 20 61 20 74 65 73 74>
```

A `TypeError` will be thrown if `object` has not mentioned methods or is not of
other type appropriate for `Buffer.from()` variants.
A `TypeError` will be thrown if `object` does not have the mentioned methods or
is not of another type appropriate for `Buffer.from()` variants.

### Class Method: `Buffer.from(string[, encoding])`
<!-- YAML
Expand All @@ -710,7 +711,7 @@ console.log(buf1.toString('latin1'));
// Prints: this is a tést
```

A `TypeError` will be thrown if `string` is not a string or other type
A `TypeError` will be thrown if `string` is not a string or another type
appropriate for `Buffer.from()` variants.

### Class Method: `Buffer.isBuffer(obj)`
Expand Down