Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: add RFC references for each status code #33671

Closed
wants to merge 2 commits into from

Conversation

Voltra
Copy link
Contributor

@Voltra Voltra commented May 31, 2020

Reference format is as follows RFC <rfc id> <section path>. Using the RFC reference makes it easier to get more information regarding the status code directly from IETF.

Checklist

Reference format: `RFC <rfc id> <section path>`
@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label May 31, 2020
Reference format is as follows RFC <rfc id> <section path>. Using the RFC reference makes it easier to get more information regarding the status code directly from IETF.
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 🙇

@Ethan-Arrowood
Copy link
Contributor

Is there any interest in duplicating this list in the HTTP docs as well? We could also link to MDN docs for these codes which is one of my go to resources for it

@Voltra
Copy link
Contributor Author

Voltra commented Jun 2, 2020

Is there any interest in duplicating this list in the HTTP docs as well? We could also link to MDN docs for these codes which is one of my go to resources for it

If there is such interest, I would be more than happy to work on it (maybe as a follow up pull request). I'm thinking about referencing, under a new section, all status code using the following format: <code> <label> <MDN link> <IETF link> (with exceptions for codes such as 509).

@Ethan-Arrowood
Copy link
Contributor

+1 for a separate PR - feel free to tag me I'll help review 😄

Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing! Thank you!

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 10, 2020

@Voltra Voltra requested a review from a team as a code owner August 10, 2020 16:07
@rickyes rickyes added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 15, 2020
rickyes pushed a commit that referenced this pull request Aug 15, 2020
Reference format: `RFC <rfc id> <section path>`

PR-URL: #33671
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@rickyes
Copy link
Contributor

rickyes commented Aug 15, 2020

Landed in 9594b54
@Voltra congratulations on your first commit to Node.js! 🎉

@rickyes rickyes closed this Aug 15, 2020
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
Reference format: `RFC <rfc id> <section path>`

PR-URL: #33671
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
Reference format: `RFC <rfc id> <section path>`

PR-URL: #33671
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants