Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: remove dynamicInstantiate loader hook #33501

Closed
wants to merge 1 commit into from
Closed

module: remove dynamicInstantiate loader hook #33501

wants to merge 1 commit into from

Commits on May 21, 2020

  1. module: remove dynamicInstantiate loader hook 

    The dynamicInstantiate loader hook requires that the hooks run in the
same global scope as the code being loaded. We don't want to commit to
this being true in the future. It stops us from sharing hooks between
multiple worker threads or isolating loader hook from the application
code.

Using `getSource` and `getGlobalPreloadCode` the same use cases should
be covered.
    @jkrems
    jkrems committed May 21, 2020
    Configuration menu
    Copy the full SHA
    817a5ba View commit details
    Browse the repository at this point in the history