repl: support optional chaining during autocompletion #33450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
changed the title
This makes sure the autocompletion is able to handle optional chaining notations. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
This refactors the repl autocompletion code for simplicity and readability. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
force-pushed
the
repl-optional-chaining-preview
branch
from
28b745c
to
8c487ad
Compare
BridgeAR
changed the title
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31373/ ✅ (green besides one known ci issue) |
jasnell
approved these changes
May 18, 2020
BridgeAR
added
the
author ready
benjamingr
reviewed
May 18, 2020
benjamingr
reviewed
May 18, 2020
benjamingr
reviewed
May 18, 2020
Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
|
CI: https://ci.nodejs.org/job/node-test-pull-request/31400/ (:green_heart:) |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 20, 2020
This makes sure the autocompletion is able to handle optional chaining notations. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: nodejs#33450 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 20, 2020
This refactors the repl autocompletion code for simplicity and readability. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: nodejs#33450 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Landed in 9de08f7...19d9e20 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This makes sure the autocompletion is able to handle optional chaining notations. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33450 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This refactors the repl autocompletion code for simplicity and readability. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33450 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
|
@BridgeAR should this go back to v12.x? it's a bit conflict heavy, so would you mind opening a manual backport if so? Feel free to remove the label otherwise :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repl: support optional chaining during autocompletion
This makes sure the autocompletion is able to handle optional
chaining notations.
repl: simplify repl autocompletion
This refactors the repl autocompletion code for simplicity and
readability.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes