Skip to content

build: run full test suite in ASAN action #33170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

build: run full test suite in ASAN action #33170

wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

Refs: #32776

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax addaleax requested a review from mmarchini April 30, 2020 17:22
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 30, 2020
@addaleax
Copy link
Member Author

Looks like there’s a few (real) issues that make test-fs-opendir flaky here.

@addaleax addaleax added the blocked PRs that are blocked by other issues or PRs. label May 6, 2020
@addaleax
Copy link
Member Author

addaleax commented May 7, 2020

Blocked on #33274 and libuv/libuv#2837

@addaleax addaleax added the review wanted PRs that need reviews. label May 7, 2020
@addaleax addaleax added build Issues and PRs related to build files or the CI. and removed blocked PRs that are blocked by other issues or PRs. meta Issues and PRs related to the general management of the project. labels May 19, 2020
@addaleax
Copy link
Member Author

@nodejs/build-files @mmarchini @gengjiawen I’ve rebased this, PTAL

mmarchini
mmarchini approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@mmarchini mmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@addaleax
Copy link
Member Author

Landed in 7c755b0 🎉

@addaleax addaleax closed this May 19, 2020
addaleax added a commit that referenced this pull request May 19, 2020
@addaleax
build: run full test suite in ASAN action
7c755b0 
Refs: #32776

PR-URL: #33170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@addaleax addaleax deleted the reenable-asan branch May 19, 2020 21:34
@gengjiawen
Copy link
Member

Great work.

codebytere pushed a commit that referenced this pull request May 21, 2020
@addaleax @codebytere
build: run full test suite in ASAN action
02e8c14 
Refs: #32776

PR-URL: #33170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
QwireyInc pushed a commit to QwireyInc/node that referenced this pull request Apr 19, 2025
@addaleax @targos
build: run full test suite in ASAN action
85ce30f 
Refs: nodejs/node#32776

PR-URL: nodejs/node#33170
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. review wanted PRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax @gengjiawen @cjihrig @mmarchini @codebytere @nodejs-github-bot