Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add required flag to FinalizationGroupError test #32990

Merged
merged 1 commit into from
Apr 23, 2020
Merged

test: add required flag to FinalizationGroupError test #32990

merged 1 commit into from
Apr 23, 2020

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Apr 22, 2020 •
edited
Loading

Related: nodejs/node-v8#156 (comment)

Note: this is target to canary-base

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 22, 2020
@gengjiawen gengjiawen merged commit 9877f80 into nodejs:canary-base Apr 23, 2020
@gengjiawen gengjiawen deleted the bugfix/test_finalization_test branch April 23, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@devsnek devsnek devsnek approved these changes

@mmarchini mmarchini mmarchini approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @targos @cjihrig @mmarchini @devsnek @himself65 @nodejs-github-bot