Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: use finished over destroy w/ cb #32809

Closed
wants to merge 2 commits into from
Closed

fs: use finished over destroy w/ cb #32809

wants to merge 2 commits into from

Commits on Apr 13, 2020

  1. fs: use finished over destroy w/ cb 

    destroy w/ is undocumented API which also will cause
a race if the stream is already destroying and potentially
invoking the callback too early and withou error.
    @ronag
    ronag committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    7494d73 View commit details
    Browse the repository at this point in the history

  2. fixup: handle cb null case

    @ronag
    ronag committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    f229cac View commit details
    Browse the repository at this point in the history