Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: doc deprecate abort and improve docs #32807

Closed
wants to merge 8 commits into from
Closed

http: doc deprecate abort and improve docs #32807

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
69a8af0
http: doc deprecate abort and improve docs
ronag Apr 13, 2020
00f23ee
fixup: lint
ronag Apr 13, 2020
083ad2e
fixup: docs
ronag Apr 13, 2020
08e542a
Apply suggestions from code review
ronag Apr 13, 2020
72b2694
fixup: further details
ronag Apr 13, 2020
ea66e37
fixup: fixes
ronag Apr 13, 2020
7c636b8
Update doc/api/deprecations.md
ronag Apr 17, 2020
7082213
fixup: request.destroy added v0.3.0
ronag Apr 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-Authored-By: Anna Henningsen <github@addaleax.net>
  • Loading branch information
@ronag @addaleax
ronag and addaleax authored Apr 13, 2020
commit 08e542a88b2565e6551251d3861339666088fddb
4 changes: 2 additions & 2 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ is finished.

### `request.destroy([error])`
<!-- YAML
added: 14.0.0
added: REPLACEME
ronag marked this conversation as resolved.
Show resolved Hide resolved
-->

* `error` {Error} Optional, an error to emit with `'error'` event.
Expand All @@ -638,7 +638,7 @@ in the response to be dropped and the socket to be destroyed.

##### `request.destroyed`
<!-- YAML
added: 14.0.0
added: REPLACEME
mcollina marked this conversation as resolved.
Show resolved Hide resolved
-->

* {boolean}
Expand Down