Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix LINT_MD_NEWER assignment #32712

Merged
merged 1 commit into from
Apr 10, 2020
Merged

build: fix LINT_MD_NEWER assignment #32712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: fix LINT_MD_NEWER assignment 
Indentation with a tab breaks the functionality, resulting in linting
all .md files when any one is changed. For consistency with the rest of
the Makefile and to restore functionality, remove indentation.

Refs: #32614 (comment)

PR-URL: #32712
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@Trott
Trott committed Apr 10, 2020
commit 203776fb7185092fa0e2e3a854c7c4595304eb83
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,9 +1233,9 @@ lint-md-build:
$(warning "Deprecated no-op target 'lint-md-build'")

ifeq ("$(wildcard tools/.mdlintstamp)","")
LINT_MD_NEWER =
LINT_MD_NEWER =
else
LINT_MD_NEWER = -newer tools/.mdlintstamp
LINT_MD_NEWER = -newer tools/.mdlintstamp
endif

LINT_MD_TARGETS = doc src lib benchmark test tools/doc tools/icu $(wildcard *.md)
Expand Down