Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: turn warnings into errors for node sources #32685

Closed
wants to merge 5 commits into from

Commits on Apr 17, 2020

  1. build: turn warnings into errors for node sources

    This commit attempts to turn compilation warnings into errors for node's
    source code.
    
    The motivation for this is to enable these errors to be reported by CI
    runs on pull requests and be able to fix them before they land.
    danbev committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    5e3988d View commit details
    Browse the repository at this point in the history
  2. tools: fix redundant-move warning in inspector

    Currently, the following warning is generated from the inspector
    protocol:
    /out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:
    In member function
    ‘virtual std::unique_ptr<node::inspector::protocol::Value>
        node::inspector::protocol::ListValue::clone() const’:
    /out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:739:21:
    error: redundant move in return statement [-Werror=redundant-move]
      739 |     return std::move(result);
          |            ~~~~~~~~~^~~~~~~~
    
    This commit removes the move for DictionaryValue and ListValue.
    danbev committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    2379516 View commit details
    Browse the repository at this point in the history
  3. build: add --error-on-warn configure flag

    This commit adds a configuration time flag named error-on-warn:
    $ ./configure --help | grep -A1 error-on-warn
      --error-on-warn       Turn compiler warnings into errors for node core
                            sources.
    
    The motivation for this is that CI jobs can use this flag to turn
    warnings into errors.
    danbev committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    b9fa8f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. Configuration menu
    Copy the full SHA
    1d0456c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9890e67 View commit details
    Browse the repository at this point in the history